Paths

Table of Contentst

Differential D19182

Add a unique key to OwnersPath on "<packageID, repositoryPHID, pathIndex>"
ClosedPublic
Actions

Authored by epriestley on Mar 7 2018, 3:47 AM.

Tags

None

Referenced Files

	F19367915: D19182.diff
	Fri, Dec 26, 2:18 PM

	F19263979: D19182.diff
	Mon, Dec 22, 6:39 PM

	F18881342: D19182.id.diff
	Nov 6 2025, 9:15 PM

	F18875833: D19182.diff
	Nov 5 2025, 7:41 PM

	F18835519: D19182.id45949.diff
	Oct 26 2025, 4:33 PM

	F18833773: D19182.diff
	Oct 26 2025, 5:42 AM

	F18784480: D19182.id45944.diff
	Oct 13 2025, 12:39 PM

	F18742796: D19182.id.diff
	Oct 2 2025, 9:22 PM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T11015: Owners has perplexing behavior when directory paths are not terminated with a slash
Commits: rP8cb273a0532b: Add a unique key to OwnersPath on "<packageID, repositoryPHID, pathIndex>"

Summary

Depends on D19181. Ref T11015. This nukes duplicates from the table if they exist, then adds a unique key.

(Duplicates should not exist and can not be added with any recent version of the web UI.)

Test Plan

Tried to add duplicates with web UI, didn't have any luck.
Explicitly added duplicates with manual INSERTs.
Viewed packages in web UI and saw duplicates.
Ran migrations, got a clean purge and a nice unique key.
There's still no way to actually hit a duplicate key error in the UI (unless you can collide hashes, I suppose), this is purely a correctness/robustness change.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Mar 7 2018, 3:47 AM

Harbormaster completed remote builds in B19757: Diff 45944.Mar 7 2018, 3:48 AM

epriestley requested review of this revision.Mar 7 2018, 3:48 AM

epriestley added a child revision: D19183: Allow owners paths to be arbitrarily long and add storage for display paths.Mar 7 2018, 3:54 AM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 7 2018, 4:31 AM

Closed by commit rP8cb273a0532b: Add a unique key to OwnersPath on "<packageID, repositoryPHID, pathIndex>" (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20180306.opath.03.purge.php

22 lines

20180306.opath.04.unique.sql

2 lines

src/

applications/

owners/

storage/

PhabricatorOwnersPath.php

5 lines

Diff 45949

resources/sql/autopatches/20180306.opath.03.purge.php

Loading...

resources/sql/autopatches/20180306.opath.04.unique.sql

Loading...

src/applications/owners/storage/PhabricatorOwnersPath.php

Loading...