Page MenuHomePhabricator

Provide context objects for remarkup mail rendering, fixing Phriction relative URIs in initial email
ClosedPublic

Authored by epriestley on Feb 16 2018, 1:18 PM.
Tags
None
Referenced Files
F13043711: D19105.diff
Wed, Apr 17, 2:51 PM
Unknown Object (File)
Sun, Apr 7, 10:48 AM
Unknown Object (File)
Sat, Mar 30, 6:55 PM
Unknown Object (File)
Sat, Mar 30, 6:55 PM
Unknown Object (File)
Sat, Mar 30, 2:18 AM
Unknown Object (File)
Wed, Mar 20, 11:01 AM
Unknown Object (File)
Wed, Mar 20, 11:00 AM
Unknown Object (File)
Feb 9 2024, 12:41 PM
Subscribers
None

Details

Summary

Fixes T10969. Ref T13077. When you create a Phriction document with a relative link ([[ ./path/to/page ]]) the initial email currently points to the wrong place.

This is because the context object (the page) isn't passed to the markup engine. Without this context, the relative link is rendered as though it appeared somewhere else (like a task or revision) where relative links don't make sense.

Test Plan

Created a new Phriction document with a relative link to [[ ./porcupine_facts/starmap ]], saw a usable link in the resulting email.

Diff Detail

Repository
rP Phabricator
Branch
phriction1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19587
Build 26514: Run Core Tests
Build 26513: arc lint + arc unit