Page MenuHomePhabricator
Differential D19103

Flesh out "phriction.document.search" slightly and provide page text for content/documents
ClosedPublic
Actions

Authored by epriestley on Feb 16 2018, 1:20 AM.
Tags
None
Referenced Files
F15432081: D19103.diff
Mon, Mar 24, 4:00 PM
F15431616: D19103.id45781.diff
Mon, Mar 24, 1:29 PM
F15406617: D19103.id45770.diff
Tue, Mar 18, 12:54 PM
F15393678: D19103.id45781.diff
Sat, Mar 15, 11:00 PM
F15393065: D19103.diff
Sat, Mar 15, 7:22 PM
Unknown Object (File)
Mar 1 2025, 3:23 AM
Unknown Object (File)
Feb 9 2025, 5:28 AM
Unknown Object (File)
Feb 9 2025, 5:28 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13077: Plans: Phriction modern "v3" APIs, Drafts
Commits
rP45403b162aa5: Flesh out "phriction.document.search" slightly and provide page text for…
Summary

Depends on D19100. Ref T13077. Adds a "content" attachment to get the actual page text. This works on both "phriction.document.search" and "phriction.content.search".

Test Plan

Called both API methods with the attachment, saw proper text content returned.

Diff Detail

Repository
rP Phabricator
Branch
phriction10
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19574
Build 26499: Run Core Tests
Build 26498: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 16 2018, 1:20 AM
Harbormaster completed remote builds in B19574: Diff 45770.Feb 16 2018, 1:21 AM
epriestley requested review of this revision.Feb 16 2018, 1:21 AM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 16 2018, 2:24 AM
Closed by commit rP45403b162aa5: Flesh out "phriction.document.search" slightly and provide page text for… (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
3 lines
applications/
phriction/
engineextension/
31 lines
storage/
10 lines
38 lines

Diff 45770

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/phriction/engineextension/PhrictionContentSearchEngineAttachment.php

Loading...
View Options

src/applications/phriction/storage/PhrictionContent.php

Loading...
View Options

src/applications/phriction/storage/PhrictionDocument.php

Loading...
Phabricator · Built by Phacility