Page MenuHomePhabricator

Give Phriction documents modern string status constants instead of numeric constants
ClosedPublic

Authored by epriestley on Feb 15 2018, 8:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 19, 7:23 PM
Unknown Object (File)
Fri, Apr 19, 10:20 AM
Unknown Object (File)
Sat, Mar 30, 6:54 PM
Unknown Object (File)
Sat, Mar 30, 6:53 PM
Unknown Object (File)
Mar 23 2024, 5:43 PM
Unknown Object (File)
Mar 23 2024, 5:43 PM
Unknown Object (File)
Mar 20 2024, 6:26 PM
Unknown Object (File)
Mar 20 2024, 6:26 PM
Subscribers
None

Details

Summary

Depends on D19099. Ref T13077. Updates Phriction documents to string constants to make API interactions cleaner and statuses more practical to extend.

This does not seem to require any transaction migrations because none of the Phriction transactions actually store status values: status is always a side effect of other edits.

Test Plan

Created, edited, deleted, moved documents. Saw appropriate UI cues. Browsed and filtered documents by status in the index.

Diff Detail

Repository
rP Phabricator
Branch
phriction9
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19570
Build 26491: Run Core Tests
Build 26490: arc lint + arc unit