Page MenuHomePhabricator

Partially clean up Phriction document status constants; introduce "phriction.document.search"
ClosedPublic

Authored by epriestley on Feb 15 2018, 5:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 7, 5:08 PM
Unknown Object (File)
Sat, Jan 4, 12:07 AM
Unknown Object (File)
Tue, Dec 31, 9:53 AM
Unknown Object (File)
Fri, Dec 27, 7:43 AM
Unknown Object (File)
Fri, Dec 27, 3:51 AM
Unknown Object (File)
Mon, Dec 23, 1:26 AM
Unknown Object (File)
Mon, Dec 23, 1:26 AM
Unknown Object (File)
Mon, Dec 23, 1:25 AM
Subscribers
None

Details

Summary

Depends on D19098. Ref T13077.

Phriction status constants currently use the "bag of statuses" approach typical of older code, and store integers in the database.

This fixes the "bag of statuses" stuff; a future change will fix the integers.

Also adds a skeleton for phriction.document.search, but doesn't implement the Conduit interface yet.

Test Plan

Searched for documents with various status constraints. Grepped for removed status constants. Viewed document list.

Diff Detail

Repository
rP Phabricator
Branch
phriction8
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19569
Build 26489: Run Core Tests
Build 26488: arc lint + arc unit