Page MenuHomePhabricator
Differential D19096

Make PhrictionContent "description" non-nullable
ClosedPublic
Actions

Authored by epriestley on Feb 15 2018, 1:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 25, 5:43 AM
Unknown Object (File)
Oct 20 2024, 11:37 PM
Unknown Object (File)
Sep 30 2024, 7:24 PM
Unknown Object (File)
Sep 25 2024, 2:59 PM
Unknown Object (File)
Sep 22 2024, 10:52 AM
Unknown Object (File)
Sep 6 2024, 2:22 AM
Unknown Object (File)
Sep 6 2024, 2:22 AM
Unknown Object (File)
Sep 6 2024, 2:22 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T6203: Adjust nullability of various questionable columns
T13077: Plans: Phriction modern "v3" APIs, Drafts
Commits
rPa965d8d6ae5a: Make PhrictionContent "description" non-nullable
Summary

Depends on D19095. Ref T6203. Ref T13077. This column is nullable in an inconsistent way. Make it non-nullable.

Also clean up one more content query on the history view.

Test Plan

Ran migration, then created and edited documents without providing a descriptino or hitting NULL exceptions.

Diff Detail

Repository
rP Phabricator
Branch
phriction5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19566
Build 26483: Run Core Tests
Build 26482: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 15 2018, 1:50 PM
Harbormaster completed remote builds in B19566: Diff 45762.Feb 15 2018, 1:51 PM
epriestley requested review of this revision.Feb 15 2018, 1:51 PM
epriestley added a child revision: D19097: Introduce a "phriction.content.search" API method to replace "phriction.history".Feb 15 2018, 2:29 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 16 2018, 1:55 AM
Closed by commit rPa965d8d6ae5a: Make PhrictionContent "description" non-nullable (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
sql/
autopatches/
2 lines
2 lines
src/
applications/
phriction/
conduit/
2 lines
2 lines
controller/
17 lines
editor/
5 lines
storage/
5 lines

Diff 45762

View Options

resources/sql/autopatches/20180215.phriction.03.descempty.sql

Loading...
View Options

resources/sql/autopatches/20180215.phriction.04.descnull.sql

Loading...
View Options

src/applications/phriction/conduit/PhrictionCreateConduitAPIMethod.php

Loading...
View Options

src/applications/phriction/conduit/PhrictionEditConduitAPIMethod.php

Loading...
View Options

src/applications/phriction/controller/PhrictionHistoryController.php

Loading...
View Options

src/applications/phriction/editor/PhrictionTransactionEditor.php

Loading...
View Options

src/applications/phriction/storage/PhrictionContent.php

Loading...
Phabricator · Built by Phacility