Page MenuHomePhabricator
Differential D19071

In Drydock log views, respect newlines
ClosedPublic
Actions

Authored by epriestley on Feb 13 2018, 11:36 AM.
Tags
None
Referenced Files
F15516812: D19071.id45727.diff
Fri, Apr 18, 9:32 PM
F15516811: D19071.id45715.diff
Fri, Apr 18, 9:32 PM
F15516527: D19071.diff
Fri, Apr 18, 7:29 PM
F15467596: D19071.diff
Thu, Apr 3, 4:32 PM
F15455518: D19071.id45727.diff
Sun, Mar 30, 2:56 AM
F15452505: D19071.id45715.diff
Sat, Mar 29, 5:23 AM
F15443975: D19071.diff
Thu, Mar 27, 7:10 AM
F15440600: D19071.id.diff
Wed, Mar 26, 1:42 PM
View All Files
Subscribers
Restricted Owners Package
Tokens
"Love" token, awarded by jcox.

Details

Reviewers
None
Maniphest Tasks
T13073: Plans: Drydock for normal software use cases where builds take more than 45 seconds
Commits
rP3ec80a36dbee: In Drydock log views, respect newlines
Summary

Depends on D19070. Ref T13073. Some messages contain an interesting story or a clever anecdote. Respect newlines during rendering to preserve authorial intent.

Test Plan

Viewed a message with linebreaks and could still read it.

Screen Shot 2018-02-13 at 3.34.41 AM.png (296×1 px, 84 KB)

Diff Detail

Repository
rP Phabricator
Branch
dry2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19518
Build 26410: Run Core Tests
Build 26409: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
drydock/
view/
1 line

Diff 45715

View Options

src/applications/drydock/view/DrydockLogListView.php

Loading...
Phabricator · Built by Phacility