Differential D19071

In Drydock log views, respect newlines
ClosedPublic
Actions

Authored by epriestley on Feb 13 2018, 11:36 AM.

Tags

None

Referenced Files

	F15381272: D19071.diff
	Fri, Mar 14, 6:46 AM

	F15379423: D19071.id45727.diff
	Thu, Mar 13, 8:58 PM

	F15309361: D19071.diff
	Thu, Mar 6, 7:15 AM

	Unknown Object (File)
	Fri, Feb 21, 3:32 PM

	Unknown Object (File)
	Tue, Feb 18, 6:13 AM

	Unknown Object (File)
	Feb 9 2025, 3:03 AM

	Unknown Object (File)
	Feb 9 2025, 3:03 AM

	Unknown Object (File)
	Feb 9 2025, 3:03 AM

View All Files

Subscribers

Restricted Owners Package

Tokens

"Love" token, awarded by jcox.

Details

Reviewers: None
Maniphest Tasks: T13073: Plans: Drydock for normal software use cases where builds take more than 45 seconds
Commits: rP3ec80a36dbee: In Drydock log views, respect newlines

Summary

Depends on D19070. Ref T13073. Some messages contain an interesting story or a clever anecdote. Respect newlines during rendering to preserve authorial intent.

Test Plan

Viewed a message with linebreaks and could still read it.

Diff Detail

Repository

rP Phabricator

Branch

dry2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19518
Build 26410: Run Core Tests
Build 26409: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 13 2018, 11:36 AM

Owners added a subscriber: Restricted Owners Package.Feb 13 2018, 11:36 AM

Harbormaster completed remote builds in B19518: Diff 45715.Feb 13 2018, 11:37 AM

epriestley requested review of this revision.Feb 13 2018, 11:37 AM

epriestley added a child revision: D19072: While waiting for a "bin/drydock" lease to activate, entertain the user with log output.Feb 13 2018, 11:50 AM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 13 2018, 9:12 PM

Closed by commit rP3ec80a36dbee: In Drydock log views, respect newlines (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

jcox awarded a token.Feb 13 2018, 9:14 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

drydock/

view/

DrydockLogListView.php

1 line

Diff 45715

View Options

src/applications/drydock/view/DrydockLogListView.php

In Drydock log views, respect newlinesClosedPublicActions