Don't let `bin/drydock lease --attributes` overwrite blueprints
ClosedPublic
Actions

Authored by epriestley on Feb 13 2018, 5:35 PM.

Details

Reviewers: None
Maniphest Tasks: T13073: Plans: Drydock for normal software use cases where builds take more than 45 seconds
Commits: rP2994753d2333: Don't let `bin/drydock lease --attributes` overwrite blueprints

Summary

Depends on D19076. Ref T13073. Blueprints are stored as an attribute and setAttributes() overwrites all attributes.

This is sorta junk but make it less obviously broken, at least.

Test Plan

Ran bin/drydock lease --type working-copy --attributes x=y without instantly getting a fatal about "no blueprint PHIDs".

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Owners added a subscriber: Restricted Owners Package.Feb 13 2018, 5:35 PM

epriestley requested review of this revision.Feb 13 2018, 5:36 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 13 2018, 9:20 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

src/

applications/

drydock/

management/

8 lines