Page MenuHomePhabricator
Differential D19073

When `bin/drydock lease` is interrupted, release leases
ClosedPublic
Actions

Authored by epriestley on Feb 13 2018, 12:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 28, 5:44 AM
Unknown Object (File)
Tue, Jan 28, 3:21 AM
Unknown Object (File)
Tue, Jan 28, 3:21 AM
Unknown Object (File)
Tue, Jan 28, 3:21 AM
Unknown Object (File)
Sat, Jan 25, 3:19 PM
Unknown Object (File)
Sat, Jan 25, 12:02 AM
Unknown Object (File)
Sat, Jan 25, 12:02 AM
Unknown Object (File)
Sat, Jan 25, 12:01 AM
View All Files
Subscribers
yelirekim
Restricted Owners Package

Details

Reviewers
None
Maniphest Tasks
T13073: Plans: Drydock for normal software use cases where builds take more than 45 seconds
Commits
rP07028cfc30cf: When `bin/drydock lease` is interrupted, release leases
Summary

Depends on D19072. Ref T13073. Currently, you can leave leases stranded by using ^C to interrupt the script. Handle signals and release leases on destruction if they haven't activated yet.

Also, print out more useful information before and after activation.

Test Plan

Mashed ^C while runnning bin/drydock lease ... --trace, saw the lease release.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
scripts/
drydock/
2 lines
init/
11 lines
src/
applications/
drydock/
blueprint/
2 lines
management/
36 lines
storage/
9 lines
worker/
2 lines

Diff 45729

View Options

scripts/drydock/drydock_control.php

Loading...
View Options

scripts/init/init-script-with-signals.php

Loading...
View Options

src/applications/drydock/blueprint/DrydockWorkingCopyBlueprintImplementation.php

Loading...
View Options

src/applications/drydock/management/DrydockManagementLeaseWorkflow.php

Loading...
View Options

src/applications/drydock/storage/DrydockLease.php

Loading...
View Options

src/applications/drydock/worker/DrydockRepositoryOperationUpdateWorker.php

Loading...
Phabricator · Built by Phacility