Paths

Table of Contentst

Differential D19055

When a build is aborted, fail the buildable
ClosedPublic
Actions

Authored by epriestley on Feb 10 2018, 7:38 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Feb 9, 9:24 AM

	Unknown Object (File)
	Sun, Feb 9, 5:20 AM

	Unknown Object (File)
	Sun, Feb 9, 5:20 AM

	Unknown Object (File)
	Sun, Feb 9, 5:20 AM

	Unknown Object (File)
	Sat, Feb 1, 9:15 PM

	Unknown Object (File)
	Tue, Jan 28, 3:19 AM

	Unknown Object (File)
	Mon, Jan 27, 9:52 AM

	Unknown Object (File)
	Fri, Jan 24, 11:56 PM

Subscribers

Restricted Owners Package

Tokens

"Manufacturing Defect?" token, awarded by yelirekim.

Details

Reviewers: None
Maniphest Tasks: T10746: Aborted build in Harbormaster still shows as building in Diffusion
T11154: Build results don't always get conferred to their buildable
T13054: Plans: Harbormaster Interactions with Differential / Chaos Reduction
Commits: rPa2d02aed2211: When a build is aborted, fail the buildable

Summary

Ref T13054. Fixes T10746. Fixes T11154. This is really a one-line fix (include ABORTED in BuildEngine->updateBuildable()) but try to structure the code a little more clearly too and reduce (at least slightly) the number of random lists of status attributes spread throughout the codebase.

Also add a header tag for buildable status.

Test Plan

Aborted a build, saw buildable fail properly.

Diff Detail

Repository

Branch

build1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19485
Build 26360: Run Core Tests
Build 26359: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 10 2018, 7:38 PM

Owners added a subscriber: Restricted Owners Package.Feb 10 2018, 7:38 PM

Harbormaster completed remote builds in B19485: Diff 45683.Feb 10 2018, 7:39 PM

epriestley requested review of this revision.Feb 10 2018, 7:39 PM

🐶 🐶 🐶

This revision was not accepted when it landed; it landed in state Needs Review.Feb 11 2018, 12:08 AM

Closed by commit rPa2d02aed2211: When a build is aborted, fail the buildable (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

harbormaster/

constants/

HarbormasterBuildStatus.php

115 lines

controller/

HarbormasterBuildableViewController.php

4 lines

engine/

HarbormasterBuildEngine.php

8 lines

storage/

HarbormasterBuildable.php

12 lines

build/

HarbormasterBuild.php

19 lines

Diff 45683

src/applications/harbormaster/constants/HarbormasterBuildStatus.php

Loading...

src/applications/harbormaster/controller/HarbormasterBuildableViewController.php

Loading...

src/applications/harbormaster/engine/HarbormasterBuildEngine.php

Loading...

src/applications/harbormaster/storage/HarbormasterBuildable.php

Loading...

src/applications/harbormaster/storage/build/HarbormasterBuild.php

Loading...