Page MenuHomePhabricator

Add an "Acting user" field to Herald
ClosedPublic

Authored by epriestley on Feb 8 2018, 5:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sep 3 2026, 11:01 AM
Unknown Object (File)
Aug 31 2026, 1:39 PM
Unknown Object (File)
Aug 30 2026, 9:40 PM
Unknown Object (File)
Aug 25 2026, 7:24 AM
Unknown Object (File)
Aug 13 2026, 2:12 AM
Unknown Object (File)
Jul 7 2026, 6:26 PM
Unknown Object (File)
Jul 1 2026, 10:07 AM
Unknown Object (File)
Jun 17 2026, 11:16 PM
Subscribers
None

Details

Summary

Ref T13053. Fixes T7804. Adds "Acting user" so you can have "always email me" stuff skip things you did or keep an eye on suspicious interns.

For the test console, the current user is the acting user.

For pushes, the pusher is the acting user.

Test Plan

Wrote acting user rules, triggered them via test console and via multiple actors on real objects.

Diff Detail

Repository
rP Phabricator
Branch
mail7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19427
Build 26274: Run Core Tests
Build 26273: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Feb 8 2018, 5:52 PM
This revision was automatically updated to reflect the committed changes.