Page MenuHomePhabricator
Differential D19031

Add an "Acting user" field to Herald
ClosedPublic
Actions

Authored by epriestley on Feb 8 2018, 5:41 PM.
Tags
None
Referenced Files
F13100882: D19031.diff
Fri, Apr 26, 8:42 PM
Unknown Object (File)
Thu, Apr 25, 12:51 AM
Unknown Object (File)
Fri, Apr 19, 7:18 PM
Unknown Object (File)
Wed, Apr 17, 4:20 PM
Unknown Object (File)
Wed, Apr 17, 2:14 PM
Unknown Object (File)
Mon, Apr 15, 3:09 PM
Unknown Object (File)
Thu, Apr 11, 6:13 AM
Unknown Object (File)
Mar 23 2024, 5:05 AM
View All 91 Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T7804: Implement an "Acting User" Herald condition
T13053: Plans: Mail Tags and Failover
Commits
rPbca9c08953bd: Add an "Acting user" field to Herald
Summary

Ref T13053. Fixes T7804. Adds "Acting user" so you can have "always email me" stuff skip things you did or keep an eye on suspicious interns.

For the test console, the current user is the acting user.

For pushes, the pusher is the acting user.

Test Plan

Wrote acting user rules, triggered them via test console and via multiple actors on real objects.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 8 2018, 5:41 PM
Harbormaster completed remote builds in B19427: Diff 45632.Feb 8 2018, 5:42 PM
epriestley requested review of this revision.Feb 8 2018, 5:42 PM
epriestley added a child revision: D19032: Render object remarkup references in a text context as "Dxxx <uri>".Feb 8 2018, 5:50 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 8 2018, 5:52 PM
Closed by commit rPbca9c08953bd: Add an "Acting user" field to Herald (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
diffusion/
engine/
6 lines
herald/
adapter/
10 lines
controller/
1 line
field/
32 lines
transactions/
editor/
1 line

Diff 45634

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/diffusion/engine/DiffusionCommitHookEngine.php

Loading...
View Options

src/applications/herald/adapter/HeraldAdapter.php

Loading...
View Options

src/applications/herald/controller/HeraldTestConsoleController.php

Loading...
View Options

src/applications/herald/field/HeraldActingUserField.php

Loading...
View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
Phabricator · Built by Phacility