Page MenuHomePhabricator

Improve PHP7 handling of include-time parser-like fatals like "class must implement all abstract methods"
ClosedPublic

Authored by epriestley on Feb 6 2018, 1:00 PM.
Tags
None
Referenced Files
F13990411: D19001.id45566.diff
Tue, Oct 22, 3:28 AM
F13977603: D19001.id45578.diff
Fri, Oct 18, 7:18 PM
Unknown Object (File)
Oct 7 2024, 9:19 AM
Unknown Object (File)
Oct 4 2024, 5:09 AM
Unknown Object (File)
Sep 30 2024, 5:12 PM
Unknown Object (File)
Sep 25 2024, 10:45 AM
Unknown Object (File)
Sep 16 2024, 3:57 AM
Unknown Object (File)
Sep 15 2024, 1:04 PM
Subscribers
None

Details

Summary

Ref T12101. Although PHP7 raises parse errors as throwables, it still just instantly fatals for some types of parser-like error.

We currently silence these, so they can cause the process to appear to exit abruptly. Instead, unsilence them.

Test Plan
  • Don't implement all abstract methods.
  • Run arc unit.
  • Before: silent fatal.
  • After: useful error.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

amckinley added inline comments.
src/moduleutils/PhutilBootloader.php
234

"immediately"

This revision is now accepted and ready to land.Feb 6 2018, 7:28 PM

I figured out how to make a computer do this for me, so hopefully I'll have fewer spelling errors in comments going forward:

Screen Shot 2018-02-06 at 11.47.45 AM.png (1×960 px, 64 KB)

  • Use more conventional spelling.
This revision was automatically updated to reflect the committed changes.