Page MenuHomePhabricator

Save mail attachments in Files, not on the actual objects
ClosedPublic

Authored by epriestley on Feb 1 2018, 8:04 PM.

Details

Summary

Depends on D18985. Ref T13053. See PHI125. Currently, mail attachments are just encoded onto the actual objects in the MetaMTAMail table.

This fails if attachments can't be encoded in JSON -- e.g., they aren't UTF8. This happens most often when revisions or commits attach patches to mail and those patches contain source code changes for files that are not encoded in UTF8.

Instead, save attachments in (and load attachments from) Files.

Test Plan

Enabled patches for mail, created a revision, saw it attach a patch. Viewed mail in web UI, saw link to download patch. Followed link, saw sensible file. Checked database, saw a filePHID. Destroyed mail with bin/remove destroy, saw attached files also destroyed.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.