HomePhabricator

Support DestructionEngine in MetaMTAMail

Description

Support DestructionEngine in MetaMTAMail

Summary:
Depends on D18984. Ref T13053. See D13408 for the original change and why this doesn't use DestructionEngine right now. The quick version is:

  • It causes us to write a destruction log, which is slightly silly (we're deleting one thing and creating another).
  • It's a little bit slower than not using DestructionEngine.

However, it gets us some stuff for free that's likely relevant now (e.g., Herald Transcript cleanup) and I'm planning to move attachments to Files, but want to be able to delete them when mail is destroyed.

The destruction log is a touch silly, but those records are very small and that log gets GC'd later without generating new logs. We could silence the log from the GC if it's ever an issue.

Test Plan: Used bin/remove destroy and bin/garbage collect --collector mail.sent to destroy mail and collect garbage.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13053

Differential Revision: https://secure.phabricator.com/D18985

Details

Provenance
epriestleyAuthored on Feb 1 2018, 7:28 PM
epriestleyPushed on Feb 2 2018, 10:37 PM
Reviewer
amckinley
Differential Revision
D18985: Support DestructionEngine in MetaMTAMail
Parents
rPcbe4e68c0722: Add a Herald action to trigger "Must Encrypt" for mail
Branches
Unknown
Tags
Unknown
Tasks
T13053: Plans: Mail Tags and Failover
Build Status
Buildable 19330
Build 26126: Run Core Tests