Page MenuHomePhabricator

Add a Herald action to trigger "Must Encrypt" for mail
ClosedPublic

Authored by epriestley on Feb 1 2018, 5:34 PM.

Details

Summary

Depends on D18983. Ref T13053. Adds a new Herald action to activate the "must encrypt" flag and drop mail content.

Test Plan
  • Created a new Herald rule:

  • Created a "dog task" (woof woof, unsecure) and a "duck task" (quack quack, secure).
  • Viewed mail for both in bin/mail and web UI, saw appropriate security/encryption behavior.
  • Viewed "Must Encrypt" in "Headers" tab for the duck mail, saw why the mail was encrypted (link to Herald rule).

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

amckinley added inline comments.
src/applications/metamta/herald/PhabricatorMailMustEncryptHeraldAction.php
19

Leftover debugging code?

58

"can be transmitted"?

This revision now requires changes to proceed.Feb 2 2018, 1:26 AM
src/applications/metamta/herald/PhabricatorMailMustEncryptHeraldAction.php
19

Yikes, thanks. Maybe I can write a lint rule to catch this.

58

I think there's technically a grammatical parsing of this, but upon re-reading it I agree it's pretty clumsy:

[ Made it required that ] mail content be transmitted only over secure channels.

In the UI, this phrase appears in the past tense (when looking at a transcript, explaining what actions Herald took) while the other one appears in the present tense (when looking at a rule, explaining what will happen when it matches) which is why the phrasing is a little weird.

  • Remove debugging code.
  • Rephrase to "Made it a requirement that mail content...".
This revision is now accepted and ready to land.Feb 2 2018, 10:11 PM
This revision was automatically updated to reflect the committed changes.