Add a Herald action to trigger "Must Encrypt" for mail
ClosedPublic
Actions

Authored by epriestley on Feb 1 2018, 5:34 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13053: Plans: Mail Tags and Failover

Commits

Summary

Depends on D18983. Ref T13053. Adds a new Herald action to activate the "must encrypt" flag and drop mail content.

Test Plan

Created a "dog task" (woof woof, unsecure) and a "duck task" (quack quack, secure).
Viewed mail for both in bin/mail and web UI, saw appropriate security/encryption behavior.
Viewed "Must Encrypt" in "Headers" tab for the duck mail, saw why the mail was encrypted (link to Herald rule).

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

epriestley requested review of this revision.Feb 1 2018, 5:35 PM

amckinley requested changes to this revision.Feb 2 2018, 1:26 AM

amckinley added inline comments.

src/applications/metamta/herald/PhabricatorMailMustEncryptHeraldAction.php
20	Leftover debugging code?
59	"can be transmitted"?

This revision now requires changes to proceed.Feb 2 2018, 1:26 AM

src/applications/metamta/herald/PhabricatorMailMustEncryptHeraldAction.php
20	Yikes, thanks. Maybe I can write a lint rule to catch this.
59	I think there's technically a grammatical parsing of this, but upon re-reading it I agree it's pretty clumsy: [ Made it required that ] mail content be transmitted only over secure channels. In the UI, this phrase appears in the past tense (when looking at a transcript, explaining what actions Herald took) while the other one appears in the present tense (when looking at a rule, explaining what will happen when it matches) which is why the phrasing is a little weird.