Use the configured viewer more consistently in the Herald commit adapter
ClosedPublic
Actions

Authored by epriestley on Jan 29 2018, 1:53 AM.

Details

Reviewers

amckinley

Maniphest Tasks

T13048: Implement a "take action only when this rule didn't match last time" repetition policy for Herald

Commits

rPd8f51dff6ec3: Use the configured viewer more consistently in the Herald commit adapter

Summary

See PHI276. Ref T13048. The fix in D18933 got one callsite, but missed the one in the callConduit() method, so the issue isn't fully fixed in production. Convert this adapter to use a real viewer (if one is available) more thoroughly.

Test Plan

Ran rules in test console, saw field values. Will test in production again.

Diff Detail

Repository

rP Phabricator

Branch

herald1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19233
Build 25982: Run Core Tests
Build 25981: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 29 2018, 1:53 AM

Harbormaster completed remote builds in B19233: Diff 45449.Jan 29 2018, 1:55 AM

epriestley requested review of this revision.Jan 29 2018, 1:55 AM

amckinley accepted this revision.Jan 29 2018, 7:33 PM

This revision is now accepted and ready to land.Jan 29 2018, 7:33 PM

Closed by commit rPd8f51dff6ec3: Use the configured viewer more consistently in the Herald commit adapter (authored by epriestley). · Explain WhyJan 29 2018, 11:00 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

herald/

HeraldCommitAdapter.php

12 lines

Diff 45449

View Options

src/applications/diffusion/herald/HeraldCommitAdapter.php

Use the configured viewer more consistently in the Herald commit adapterClosedPublicActions