Paths

Table of Contentst

Differential D18904

Remove "passwordHash" and "passwordSalt" from User objects
ClosedPublic
Actions

Authored by epriestley on Jan 22 2018, 1:20 AM.

Details

Reviewers

amckinley

Maniphest Tasks

T13043: Improve authentication revocation behaviors

Commits

rPcab2bba6f2f7: Remove "passwordHash" and "passwordSalt" from User objects

Summary

Ref T13043. After D18903, this data has migrated to shared infrastructure and has no remaining readers or writers.

Just delete it now, since the cost of a mistake here is very small (users need to "Forgot Password?" and pick a new password).

Test Plan

Grepped for passwordHash, passwordSalt, and variations.

Diff Detail

Repository

rP Phabricator

Branch

revoke14

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19107
Build 25795: Run Core Tests
Build 25794: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 22 2018, 1:20 AM

Harbormaster completed remote builds in B19107: Diff 45320.Jan 22 2018, 1:21 AM

epriestley requested review of this revision.Jan 22 2018, 1:21 AM

epriestley added a child revision: D18906: Add a rate limit for guessing old passwords when changing passwords.Jan 22 2018, 1:52 AM

amckinley accepted this revision.Jan 23 2018, 7:48 PM

This revision is now accepted and ready to land.Jan 23 2018, 7:48 PM

Closed by commit rPcab2bba6f2f7: Remove "passwordHash" and "passwordSalt" from User objects (authored by epriestley). · Explain WhyJan 23 2018, 9:44 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20180121.auth.05.accountnuke.sql

5 lines

src/

applications/

people/

storage/

PhabricatorUser.php

4 lines

Diff 45320

View Options

resources/sql/autopatches/20180121.auth.05.accountnuke.sql