Page MenuHomePhabricator

Fix a fatal in blame when the viewer can't see a revision because of a permission issue
ClosedPublic

Authored by epriestley on Jan 19 2018, 9:41 PM.
Tags
None
Referenced Files
F15337149: D18884.diff
Sun, Mar 9, 4:26 AM
F15293374: D18884.diff
Wed, Mar 5, 3:59 AM
Unknown Object (File)
Thu, Feb 27, 10:41 PM
Unknown Object (File)
Feb 12 2025, 5:04 PM
Unknown Object (File)
Feb 9 2025, 4:57 AM
Unknown Object (File)
Feb 9 2025, 4:57 AM
Unknown Object (File)
Feb 9 2025, 4:57 AM
Unknown Object (File)
Jan 30 2025, 2:42 PM
Subscribers
None
Tokens
"Yellow Medal" token, awarded by allixsenos.

Details

Summary

Fixes T13040. To reproduce:

  • View a file with blame enabled, where some line has an associated revision (say, D123).
  • Edit D123 so it exists and is a valid revision, but the viewer can't see it.
  • Reload the page.

Instead, only add revisions to the map if we actually managed to load them.

Test Plan

Page no longer fatals.

Diff Detail

Repository
rP Phabricator
Branch
permission1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19082
Build 25748: Run Core Tests
Build 25747: arc lint + arc unit