Fix Diffusion fatal when blame commits refer to broken Differential revisions
AbandonedPublic
Actions

Authored by allixsenos on Jan 17 2018, 1:39 AM.

Details

Reviewers: None
Maniphest Tasks: T13040: Fatal in Diffusion blame with missing leaves (deleted repository)

Summary

When viewing Diffusion blame on a file which has a commit that references a Differential code review on a deleted repository, the ajax blame call fatals out.

While deleting repositories is clearly called out as a dangerous action it is sometimes a necessary one when repositories grow too large and need to be "rebooted".

fixes T13040

Test Plan

Create new repo
Create code review against repo
Land code review
Push code to a new repo on same instance
Delete old repo
Open blame for file
Blame does not open
Apply patch
Blame opens

Diff Detail

Repository

rP Phabricator

Branch

nofatalonmissingcommit (branched from master)

Lint

Lint Passed

Unit

Tests Skipped

Build Status

Buildable 19045
Build 25698: Run Core Tests
Build 25697: arc lint + arc unit

Event Timeline

allixsenos created this revision.Jan 17 2018, 1:39 AM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 17 2018, 1:39 AM

Herald added a subscriber: epriestley. · View Herald Transcript

allixsenos retitled this revision from Fix Diffusion fatal when blame commits refer to broken Differential revisions, fixes T13040 to Fix Diffusion fatal when blame commits refer to broken Differential revisions.Jan 17 2018, 1:40 AM

allixsenos edited the summary of this revision. (Show Details)

allixsenos added a task: T13040: Fatal in Diffusion blame with missing leaves (deleted repository).

Harbormaster completed remote builds in B19045: Diff 45262.Jan 17 2018, 1:40 AM

allixsenos requested review of this revision.Jan 17 2018, 1:40 AM