Page MenuHomePhabricator

Fix Diffusion fatal when blame commits refer to broken Differential revisions
AbandonedPublic

Authored by allixsenos on Jan 17 2018, 1:39 AM.

Details

Summary

When viewing Diffusion blame on a file which has a commit that references a Differential code review on a deleted repository, the ajax blame call fatals out.

While deleting repositories is clearly called out as a dangerous action it is sometimes a necessary one when repositories grow too large and need to be "rebooted".

fixes T13040

Test Plan
  1. Create new repo
  2. Create code review against repo
  3. Land code review
  4. Push code to a new repo on same instance
  5. Delete old repo
  6. Open blame for file
  7. Blame does not open
  8. Apply patch
  9. Blame opens

Diff Detail

Repository
rP Phabricator
Branch
nofatalonmissingcommit (branched from master)
Lint
Lint OK
Unit
Unit Tests Skipped
Build Status
Buildable 19045
Build 25698: Run Core Tests
Build 25697: arc lint + arc unit

Event Timeline

allixsenos retitled this revision from Fix Diffusion fatal when blame commits refer to broken Differential revisions, fixes T13040 to Fix Diffusion fatal when blame commits refer to broken Differential revisions.Jan 17 2018, 1:40 AM
allixsenos edited the summary of this revision. (Show Details)