Diffusion Phabricator 3038d564a6d8

Allow bulk edits to be made silently if you have CLI access
3038d564a6d8
Actions

Tags

None

Referenced Files

	F5386245: Screen Shot 2018-01-19 at 10.17.59 AM.png
	Jan 19 2018, 9:25 PM

Subscribers

None

Description

Allow bulk edits to be made silently if you have CLI access

Summary:
Fixes T13042. This hooks up the new "silent" mode from D18882 and makes it actually work.

The UI (where we tell you to go run some command and then reload the page) is pretty clumsy, but should solve some problems for now and can be cleaned up eventually. The actual mechanics (timeline aggregation, Herald interaction, etc.) are on firmer ground.

Test Plan:

Made a normal bulk edit, got mail and feed stories.
Made a silent bulk edit, no mail and no feed.
Saw "Silent Edit" marker in timeline for silent edits:

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13042

Differential Revision: https://secure.phabricator.com/D18883

Details

Provenance

epriestley	Authored on Jan 19 2018, 6:08 PM
epriestley	Pushed on Jan 19 2018, 9:24 PM

Reviewer

Differential Revision

D18883: Allow bulk edits to be made silently if you have CLI access

Parents

rP8b12fa6d6ed0: Prepare TransactionEditor for silent transactions via bulk edit

Branches

Unknown

Tags

Unknown

Tasks

T13042: Add a "silent" mode to bulk edits

Build Status

Buildable 19081
Build 25746: Run Core Tests

Event Timeline

epriestley committed rP3038d564a6d8: Allow bulk edits to be made silently if you have CLI access (authored by epriestley).Jan 19 2018, 9:24 PM

epriestley added a task: T13042: Add a "silent" mode to bulk edits.

Harbormaster completed building B19081: rP3038d564a6d8: Allow bulk edits to be made silently if you have CLI access.Jan 19 2018, 9:26 PM

Changes (13)

Path

Size

bin/

resources/

sql/

autopatches/

20180119.bulk.01.silent.sql

scripts/

manage_bulk.php

	setup/
	mail/

	manage_bulk.php
	manage_mail.php

src/

__phutil_library_map__.php

applications/

daemon/

controller/

PhabricatorDaemonBulkJobMonitorController.php

transactions/

bulk/

PhabricatorEditEngineBulkJobType.php

PhabricatorBulkManagementMakeSilentWorkflow.php

	transactions/	bulk/	management/
		auth/	management/

	PhabricatorBulkManagementWorkflow.php
	PhabricatorAuthManagementWorkflow.php

infrastructure/

daemon/

workers/

storage/

PhabricatorWorkerBulkJob.php

internationalization/

translation/

PhabricatorUSEnglishTranslation.php

view/

phui/

PHUITimelineEventView.php

rP3038d564a6d8

bin/bulk

Loading...

resources/sql/autopatches/20180119.bulk.01.silent.sql

Loading...

scripts/manage_bulk.php

Loading...

scripts/setup/manage_bulk.php

Loading...

src/__phutil_library_map__.php

Loading...

src/applications/daemon/controller/PhabricatorDaemonBulkJobMonitorController.php

Loading...

src/applications/transactions/bulk/PhabricatorEditEngineBulkJobType.php

Loading...

src/applications/transactions/bulk/management/PhabricatorBulkManagementMakeSilentWorkflow.php

Loading...

src/applications/transactions/bulk/management/PhabricatorBulkManagementWorkflow.php

Loading...

src/infrastructure/daemon/workers/storage/PhabricatorWorkerBulkJob.php

Loading...

src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php

Loading...

src/view/phui/PHUITimelineEventView.php

Loading...