Page MenuHomePhabricator

Fix a fatal in blame when the viewer can't see a revision because of a permission issue
ClosedPublic

Authored by epriestley on Jan 19 2018, 9:41 PM.
Tags
None
Referenced Files
F18874465: D18884.id45295.diff
Wed, Nov 5, 2:37 PM
F18857067: D18884.id.diff
Sat, Nov 1, 1:01 PM
F18852388: D18884.diff
Fri, Oct 31, 8:25 AM
F18851131: D18884.id45297.diff
Thu, Oct 30, 10:27 PM
F18705324: D18884.diff
Sep 28 2025, 10:49 AM
F18699361: D18884.id.diff
Sep 27 2025, 12:45 PM
F18683934: D18884.diff
Sep 26 2025, 8:32 AM
F18675357: D18884.diff
Sep 25 2025, 5:39 PM
Subscribers
None
Tokens
"Yellow Medal" token, awarded by allixsenos.

Details

Summary

Fixes T13040. To reproduce:

  • View a file with blame enabled, where some line has an associated revision (say, D123).
  • Edit D123 so it exists and is a valid revision, but the viewer can't see it.
  • Reload the page.

Instead, only add revisions to the map if we actually managed to load them.

Test Plan

Page no longer fatals.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable