Page MenuHomePhabricator

Fix a fatal in blame when the viewer can't see a revision because of a permission issue
ClosedPublic

Authored by epriestley on Jan 19 2018, 9:41 PM.

Details

Summary

Fixes T13040. To reproduce:

  • View a file with blame enabled, where some line has an associated revision (say, D123).
  • Edit D123 so it exists and is a valid revision, but the viewer can't see it.
  • Reload the page.

Instead, only add revisions to the map if we actually managed to load them.

Test Plan

Page no longer fatals.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.