Page MenuHomePhabricator

Fix a fatal in blame when the viewer can't see a revision because of a permission issue
ClosedPublic

Authored by epriestley on Jan 19 2018, 9:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 16, 10:56 PM
Unknown Object (File)
Wed, Nov 6, 12:09 AM
Unknown Object (File)
Wed, Nov 6, 12:09 AM
Unknown Object (File)
Wed, Nov 6, 12:09 AM
Unknown Object (File)
Mon, Nov 4, 10:36 AM
Unknown Object (File)
Oct 22 2024, 4:01 PM
Unknown Object (File)
Oct 20 2024, 12:59 AM
Unknown Object (File)
Oct 9 2024, 9:03 PM
Subscribers
None
Tokens
"Yellow Medal" token, awarded by allixsenos.

Details

Summary

Fixes T13040. To reproduce:

  • View a file with blame enabled, where some line has an associated revision (say, D123).
  • Edit D123 so it exists and is a valid revision, but the viewer can't see it.
  • Reload the page.

Instead, only add revisions to the map if we actually managed to load them.

Test Plan

Page no longer fatals.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable