Restore "Tags" and "Subscribers" edit capabilities to Maniphest bulk editor
ClosedPublic
Actions

Authored by epriestley on Jan 11 2018, 7:08 PM.

Details

Reviewers

Maniphest Tasks

T8740: Batch edit Add Project does not perform the action requested
T13025: Turn bulk editor into a generic piece of EditEngine infrastructure with Custom Field support

Commits

rP0cad6021b6f4: Restore "Tags" and "Subscribers" edit capabilities to Maniphest bulk editor

Summary

Depends on D18867. Ref T13025. Fixes T8740. Rebuilds the tag/subscriber actions (add, remove, set) into the bulk editor.

Test Plan

Added, removed and set these values via bulk edit.

Diff Detail

Repository

rP Phabricator

Branch

bulk8

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19038
Build 25687: Run Core Tests
Build 25686: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 11 2018, 7:08 PM

Harbormaster completed remote builds in B19038: Diff 45254.Jan 11 2018, 7:10 PM

epriestley requested review of this revision.Jan 11 2018, 7:10 PM

amckinley accepted this revision.Jan 17 2018, 6:30 PM

This revision is now accepted and ready to land.Jan 17 2018, 6:30 PM

epriestley mentioned this in T8740: Batch edit Add Project does not perform the action requested.Jan 19 2018, 2:31 PM

epriestley edited the summary of this revision. (Show Details)

epriestley added a task: T8740: Batch edit Add Project does not perform the action requested.

Closed by commit rP0cad6021b6f4: Restore "Tags" and "Subscribers" edit capabilities to Maniphest bulk editor (authored by epriestley). · Explain WhyJan 19 2018, 8:47 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

applications/

project/

engineextension/

PhabricatorProjectsEditEngineExtension.php

20 lines

subscriptions/

engineextension/

PhabricatorSubscriptionsEditEngineExtension.php

20 lines

transactions/

bulk/

PhabricatorEditEngineBulkJobType.php

6 lines

type/

BulkTokenizerParameterType.php

40 lines

editengine/

PhabricatorEditEngine.php

2 lines

editfield/

PhabricatorEditField.php

13 lines

edittype/

PhabricatorEdgeEditType.php

24 lines

Diff 45254

View Options

src/__phutil_library_map__.php

View Options

src/applications/project/engineextension/PhabricatorProjectsEditEngineExtension.php

View Options

src/applications/subscriptions/engineextension/PhabricatorSubscriptionsEditEngineExtension.php

View Options

src/applications/transactions/bulk/PhabricatorEditEngineBulkJobType.php

View Options

src/applications/transactions/bulk/type/BulkTokenizerParameterType.php

View Options

src/applications/transactions/editengine/PhabricatorEditEngine.php

View Options

src/applications/transactions/editfield/PhabricatorEditField.php

View Options

src/applications/transactions/edittype/PhabricatorEdgeEditType.php

Restore "Tags" and "Subscribers" edit capabilities to Maniphest bulk editorClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 45254

src/__phutil_library_map__.php

src/applications/project/engineextension/PhabricatorProjectsEditEngineExtension.php

src/applications/subscriptions/engineextension/PhabricatorSubscriptionsEditEngineExtension.php

src/applications/transactions/bulk/PhabricatorEditEngineBulkJobType.php

src/applications/transactions/bulk/type/BulkTokenizerParameterType.php

src/applications/transactions/editengine/PhabricatorEditEngine.php

src/applications/transactions/editfield/PhabricatorEditField.php

src/applications/transactions/edittype/PhabricatorEdgeEditType.php

Restore "Tags" and "Subscribers" edit capabilities to Maniphest bulk editor
ClosedPublic
Actions

Revision Contents
Changeset List