Page MenuHomePhabricator

Restore bulk edit support for remarkup fields (description, add comment)
ClosedPublic

Authored by epriestley on Jan 11 2018, 6:17 PM.
Tags
None
Referenced Files
F13314088: D18867.id.diff
Tue, Jun 11, 4:38 PM
F13312729: D18867.diff
Tue, Jun 11, 7:00 AM
F13299088: D18867.diff
Fri, Jun 7, 7:36 AM
F13249599: D18867.id45283.diff
Fri, May 24, 9:37 AM
F13232976: D18867.diff
Tue, May 21, 1:36 AM
F13214534: D18867.diff
Fri, May 17, 11:14 AM
F13211466: D18867.diff
Fri, May 17, 5:47 AM
F13196797: D18867.diff
May 12 2024, 11:34 PM
Subscribers
None

Details

Summary

Depends on D18866. Ref T13025. Fixes T12415. This makes the old "Add Comment" action work, and adds support for a new "Set description to" action (possibly, I could imagine "append description" being useful some day, maybe).

The implementation is just a <textarea />, not a whole fancy remarkup box with [Bold] [Italic] ... buttons, preview, typeaheads, etc. It would be nice to enrich this eventually but doing the rendering in pure JS is currently very involved.

This requires a little bit of gymnastics to get the transaction populated properly, and adds some extra validation since we need some code there anyway.

Test Plan
  • Changed the description of a task via bulk editor.
  • Added a comment to a task via bulk editor.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable