Page MenuHomePhabricator

Restore bulk edit support for remarkup fields (description, add comment)
ClosedPublic

Authored by epriestley on Jan 11 2018, 6:17 PM.
Tags
None
Referenced Files
F13528121: D18867.diff
Fri, Jul 26, 6:54 PM
Unknown Object (File)
Wed, Jul 17, 8:32 AM
Unknown Object (File)
Tue, Jul 16, 5:58 PM
Unknown Object (File)
Sat, Jul 13, 9:27 AM
Unknown Object (File)
Sat, Jul 13, 4:50 AM
Unknown Object (File)
Fri, Jul 12, 11:12 AM
Unknown Object (File)
Tue, Jul 9, 4:04 AM
Unknown Object (File)
Thu, Jun 27, 7:56 PM
Subscribers
None

Details

Summary

Depends on D18866. Ref T13025. Fixes T12415. This makes the old "Add Comment" action work, and adds support for a new "Set description to" action (possibly, I could imagine "append description" being useful some day, maybe).

The implementation is just a <textarea />, not a whole fancy remarkup box with [Bold] [Italic] ... buttons, preview, typeaheads, etc. It would be nice to enrich this eventually but doing the rendering in pure JS is currently very involved.

This requires a little bit of gymnastics to get the transaction populated properly, and adds some extra validation since we need some code there anyway.

Test Plan
  • Changed the description of a task via bulk editor.
  • Added a comment to a task via bulk editor.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable