Page MenuHomePhabricator

Restore bulk edit support for remarkup fields (description, add comment)
ClosedPublic

Authored by epriestley on Jan 11 2018, 6:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 24, 4:02 PM
Unknown Object (File)
Feb 3 2024, 5:31 PM
Unknown Object (File)
Jan 30 2024, 7:25 PM
Unknown Object (File)
Jan 25 2024, 12:15 AM
Unknown Object (File)
Jan 21 2024, 8:30 PM
Unknown Object (File)
Jan 17 2024, 11:39 AM
Unknown Object (File)
Jan 4 2024, 6:18 AM
Unknown Object (File)
Dec 27 2023, 12:39 PM
Subscribers
None

Details

Summary

Depends on D18866. Ref T13025. Fixes T12415. This makes the old "Add Comment" action work, and adds support for a new "Set description to" action (possibly, I could imagine "append description" being useful some day, maybe).

The implementation is just a <textarea />, not a whole fancy remarkup box with [Bold] [Italic] ... buttons, preview, typeaheads, etc. It would be nice to enrich this eventually but doing the rendering in pure JS is currently very involved.

This requires a little bit of gymnastics to get the transaction populated properly, and adds some extra validation since we need some code there anyway.

Test Plan
  • Changed the description of a task via bulk editor.
  • Added a comment to a task via bulk editor.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable