Page MenuHomePhabricator

Restore bulk edit support for remarkup fields (description, add comment)
ClosedPublic

Authored by epriestley on Jan 11 2018, 6:17 PM.
Tags
None
Referenced Files
F15417328: D18867.id45253.diff
Thu, Mar 20, 4:36 PM
F15415378: D18867.id45283.diff
Thu, Mar 20, 5:40 AM
F15414591: D18867.id45283.diff
Thu, Mar 20, 1:22 AM
F15407255: D18867.id.diff
Tue, Mar 18, 4:32 PM
F15402489: D18867.diff
Mon, Mar 17, 10:48 PM
F15401335: D18867.id.diff
Mon, Mar 17, 5:06 PM
F15382407: D18867.diff
Fri, Mar 14, 12:12 PM
F15376481: D18867.diff
Thu, Mar 13, 3:57 AM
Subscribers
None

Details

Summary

Depends on D18866. Ref T13025. Fixes T12415. This makes the old "Add Comment" action work, and adds support for a new "Set description to" action (possibly, I could imagine "append description" being useful some day, maybe).

The implementation is just a <textarea />, not a whole fancy remarkup box with [Bold] [Italic] ... buttons, preview, typeaheads, etc. It would be nice to enrich this eventually but doing the rendering in pure JS is currently very involved.

This requires a little bit of gymnastics to get the transaction populated properly, and adds some extra validation since we need some code there anyway.

Test Plan
  • Changed the description of a task via bulk editor.
  • Added a comment to a task via bulk editor.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable