Make bulk editor working set editable and more homogenous
ClosedPublic
Actions

Authored by epriestley on Nov 30 2017, 1:39 PM.

Details

Reviewers

Maniphest Tasks

T10005: Implement an ApplicationEditor-based Bulk Editor
T11286: make it possible to remove tasks from a batch edit tasks workflow
T13025: Turn bulk editor into a generic piece of EditEngine infrastructure with Custom Field support

Commits

rPad659627b3e9: Make bulk editor working set editable and more homogenous

Summary

Ref T13025. See PHI50. Fixes T11286. Ref T10005. Begin modernizing the bulk editor.

For T10005 ("move the bulk editor to modern infrastructure"), rewrite the rendering of the editable set so that it is application-agnostic and can work with any kind of object.

For T11286 ("let users de-select items in the working set"), make the working set editable.

Test Plan

Deselected some objects, applied an edit, saw the edit apply to only selected objects.

Diff Detail

Repository

rP Phabricator

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Nov 30 2017, 1:39 PM

epriestley requested review of this revision.Nov 30 2017, 3:28 PM

epriestley added a child revision: D18806: Rebuild the bulk editor on SearchEngine.

New interface looks great!

webroot/rsrc/js/phui/behavior-phui-selectable-list.js
24	"selection"

This revision is now accepted and ready to land.Nov 30 2017, 10:59 PM

Spelling fix.

Closed by commit rPad659627b3e9: Make bulk editor working set editable and more homogenous (authored by epriestley). · Explain WhyJan 19 2018, 8:39 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		resources/celerity/map.php (17 lines)
M		src/applications/maniphest/controller/ManiphestBatchEditController.php (77 lines)
M		src/view/phui/PHUIObjectItemView.php (43 lines)
M		webroot/rsrc/css/phui/object-item/phui-oi-list-view.css (19 lines)
M		webroot/rsrc/css/phui/phui-box.css (4 lines)
A	M	webroot/rsrc/js/phui/behavior-phui-selectable-list.js (44 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	45118	1b76250		Nov 30 2017, 1:39 PM	★	★
Diff 2	45139	1b76250	- Spelling fix.	Nov 30 2017, 11:18 PM	★	★
Diff 3	45277	3e983b5	rPad659627b3e931256e295efda941775c4020b713	Jan 19 2018, 8:39 PM	★	★

Status	Author	Revision
Closed	epriestley	D18868 Restore "Tags" and "Subscribers" edit capabilities to Maniphest bulk editor
Closed	epriestley	D18867 Restore bulk edit support for remarkup fields (description, add comment)
Closed	epriestley	D18866 Support "select" types in bulk editor (status, priority)
Closed	epriestley	D18864 Remove the Maniphest-specific bulk job type
Closed	epriestley	D18863 Define bulk edits in terms of EditEngine, not hard-coded ad-hoc definitions
Closed	epriestley	D18862 Provide a generic transaction-oriented bulk job worker
Closed	epriestley	D18806 Rebuild the bulk editor on SearchEngine
Closed	epriestley	D18805 Make bulk editor working set editable and more homogenous