Page MenuHomePhabricator

Make bulk editor working set editable and more homogenous
ClosedPublic

Authored by epriestley on Nov 30 2017, 1:39 PM.

Details

Summary

Ref T13025. See PHI50. Fixes T11286. Ref T10005. Begin modernizing the bulk editor.

For T10005 ("move the bulk editor to modern infrastructure"), rewrite the rendering of the editable set so that it is application-agnostic and can work with any kind of object.

For T11286 ("let users de-select items in the working set"), make the working set editable.

Test Plan

  • Deselected some objects, applied an edit, saw the edit apply to only selected objects.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Nov 30 2017, 1:39 PM
epriestley requested review of this revision.Nov 30 2017, 3:28 PM
amckinley accepted this revision.Nov 30 2017, 10:59 PM

New interface looks great!

webroot/rsrc/js/phui/behavior-phui-selectable-list.js
24

"selection"

This revision is now accepted and ready to land.Nov 30 2017, 10:59 PM
  • Spelling fix.
This revision was automatically updated to reflect the committed changes.