Page MenuHomePhabricator

Remove an obsolete comment about Mercurial SSH error behavior
ClosedPublic

Authored by epriestley on Jan 4 2018, 8:50 PM.
Tags
None
Referenced Files
F15458415: D18856.id45231.diff
Sun, Mar 30, 11:52 PM
F15458182: D18856.id45236.diff
Sun, Mar 30, 9:31 PM
F15454705: D18856.id.diff
Sat, Mar 29, 7:51 PM
F15452813: D18856.diff
Sat, Mar 29, 7:27 AM
F15450070: D18856.diff
Fri, Mar 28, 1:42 PM
F15435233: D18856.id45231.diff
Tue, Mar 25, 7:28 AM
F15409524: D18856.id45236.diff
Wed, Mar 19, 4:39 AM
Unknown Object (File)
Feb 24 2025, 9:00 PM
Subscribers
None

Details

Summary

Depends on D18855. Ref T13036. This comment no longer seems to be accurate: anything we send over stderr is faithfully shown to the user with recent clients.

From this document, the missing sauce may have been:

A generic error response type is also supported. It consists of a an error
message written to ``stderr`` followed by ``\n-\n``. In addition, ``\n`` is
written to ``stdout``.

That is, writing "\n" to stdout in addition to writing the error to stderr. However, this no longer appears to be necessary.

I think the modern client behavior is generally sensible (and consistent with the behavior of Git and Subversion) so this probably isn't a bug or me making a mistake.

Test Plan

With a modern client, threw some arbitrary exception during execution. Observed a helpful message on the client with no additional steps.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable