Page MenuHomePhabricator

Remove an obsolete comment about Mercurial SSH error behavior
ClosedPublic

Authored by epriestley on Jan 4 2018, 8:50 PM.
Tags
None
Referenced Files
F18748226: D18856.id.diff
Fri, Oct 3, 7:59 PM
F18745801: D18856.id45236.diff
Fri, Oct 3, 9:28 AM
F18741309: D18856.diff
Thu, Oct 2, 11:43 AM
F18728272: D18856.diff
Tue, Sep 30, 9:15 AM
F18684322: D18856.id.diff
Fri, Sep 26, 9:07 AM
F18679228: D18856.id45231.diff
Fri, Sep 26, 12:35 AM
F18509223: D18856.id.diff
Sep 5 2025, 3:18 AM
F18501919: D18856.diff
Sep 4 2025, 10:03 PM
Subscribers
None

Details

Summary

Depends on D18855. Ref T13036. This comment no longer seems to be accurate: anything we send over stderr is faithfully shown to the user with recent clients.

From this document, the missing sauce may have been:

A generic error response type is also supported. It consists of a an error
message written to ``stderr`` followed by ``\n-\n``. In addition, ``\n`` is
written to ``stdout``.

That is, writing "\n" to stdout in addition to writing the error to stderr. However, this no longer appears to be necessary.

I think the modern client behavior is generally sensible (and consistent with the behavior of Git and Subversion) so this probably isn't a bug or me making a mistake.

Test Plan

With a modern client, threw some arbitrary exception during execution. Observed a helpful message on the client with no additional steps.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable