Page MenuHomePhabricator

Remove an obsolete comment about Mercurial SSH error behavior
ClosedPublic

Authored by epriestley on Jan 4 2018, 8:50 PM.
Tags
None
Referenced Files
F18059250: D18856.id45236.diff
Mon, Aug 4, 10:56 AM
F17983722: D18856.id.diff
Fri, Aug 1, 8:11 PM
F17946303: D18856.diff
Thu, Jul 31, 2:11 PM
F17922688: D18856.diff
Wed, Jul 30, 7:08 AM
F17817616: D18856.id45231.diff
Fri, Jul 25, 11:42 PM
F17807190: D18856.diff
Fri, Jul 25, 2:40 PM
F17782427: D18856.id.diff
Thu, Jul 24, 8:13 AM
F17755127: D18856.diff
Tue, Jul 22, 11:56 AM
Subscribers
None

Details

Summary

Depends on D18855. Ref T13036. This comment no longer seems to be accurate: anything we send over stderr is faithfully shown to the user with recent clients.

From this document, the missing sauce may have been:

A generic error response type is also supported. It consists of a an error
message written to ``stderr`` followed by ``\n-\n``. In addition, ``\n`` is
written to ``stdout``.

That is, writing "\n" to stdout in addition to writing the error to stderr. However, this no longer appears to be necessary.

I think the modern client behavior is generally sensible (and consistent with the behavior of Git and Subversion) so this probably isn't a bug or me making a mistake.

Test Plan

With a modern client, threw some arbitrary exception during execution. Observed a helpful message on the client with no additional steps.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable