Page MenuHomePhabricator

Remove an obsolete comment about Mercurial SSH error behavior
ClosedPublic

Authored by epriestley on Jan 4 2018, 8:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jul 3, 11:30 AM
Unknown Object (File)
Tue, Jun 21, 10:17 PM
Unknown Object (File)
Jun 4 2022, 8:35 PM
Unknown Object (File)
Jun 4 2022, 6:23 PM
Unknown Object (File)
Jun 2 2022, 1:14 PM
Unknown Object (File)
Jun 2 2022, 3:19 AM
Unknown Object (File)
May 29 2022, 10:52 PM
Unknown Object (File)
May 27 2022, 5:06 PM
Subscribers
None

Details

Summary

Depends on D18855. Ref T13036. This comment no longer seems to be accurate: anything we send over stderr is faithfully shown to the user with recent clients.

From this document, the missing sauce may have been:

A generic error response type is also supported. It consists of a an error
message written to ``stderr`` followed by ``\n-\n``. In addition, ``\n`` is
written to ``stdout``.

That is, writing "\n" to stdout in addition to writing the error to stderr. However, this no longer appears to be necessary.

I think the modern client behavior is generally sensible (and consistent with the behavior of Git and Subversion) so this probably isn't a bug or me making a mistake.

Test Plan

With a modern client, threw some arbitrary exception during execution. Observed a helpful message on the client with no additional steps.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable