Page MenuHomePhabricator

Remove an obsolete comment about Mercurial SSH error behavior

Authored by epriestley on Jan 4 2018, 8:50 PM.
Referenced Files
Unknown Object (File)
Sat, Sep 24, 2:49 AM
Unknown Object (File)
Mon, Sep 19, 11:27 PM
Unknown Object (File)
Mon, Sep 19, 3:43 AM
Unknown Object (File)
Sat, Sep 17, 1:21 AM
Unknown Object (File)
Thu, Sep 15, 6:38 PM
Unknown Object (File)
Wed, Sep 14, 11:20 PM
Unknown Object (File)
Tue, Sep 6, 8:42 PM
Unknown Object (File)
Sat, Sep 3, 3:07 PM



Depends on D18855. Ref T13036. This comment no longer seems to be accurate: anything we send over stderr is faithfully shown to the user with recent clients.

From this document, the missing sauce may have been:

A generic error response type is also supported. It consists of a an error
message written to ``stderr`` followed by ``\n-\n``. In addition, ``\n`` is
written to ``stdout``.

That is, writing "\n" to stdout in addition to writing the error to stderr. However, this no longer appears to be necessary.

I think the modern client behavior is generally sensible (and consistent with the behavior of Git and Subversion) so this probably isn't a bug or me making a mistake.

Test Plan

With a modern client, threw some arbitrary exception during execution. Observed a helpful message on the client with no additional steps.

Diff Detail

rP Phabricator
Lint Passed
Tests Passed
Build Status
Buildable 19013
Build 25647: Run Core Tests
Build 25646: arc lint + arc unit