Page MenuHomePhabricator

Remove an obsolete comment about Mercurial SSH error behavior
ClosedPublic

Authored by epriestley on Jan 4 2018, 8:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Aug 9, 4:00 AM
Unknown Object (File)
Fri, Aug 5, 11:12 AM
Unknown Object (File)
Tue, Aug 2, 11:56 AM
Unknown Object (File)
Sun, Jul 31, 4:20 AM
Unknown Object (File)
Tue, Jul 26, 9:12 AM
Unknown Object (File)
Sun, Jul 24, 11:07 PM
Unknown Object (File)
Jul 3 2022, 11:30 AM
Unknown Object (File)
Jun 21 2022, 10:17 PM
Subscribers
None

Details

Summary

Depends on D18855. Ref T13036. This comment no longer seems to be accurate: anything we send over stderr is faithfully shown to the user with recent clients.

From this document, the missing sauce may have been:

A generic error response type is also supported. It consists of a an error
message written to ``stderr`` followed by ``\n-\n``. In addition, ``\n`` is
written to ``stdout``.

That is, writing "\n" to stdout in addition to writing the error to stderr. However, this no longer appears to be necessary.

I think the modern client behavior is generally sensible (and consistent with the behavior of Git and Subversion) so this probably isn't a bug or me making a mistake.

Test Plan

With a modern client, threw some arbitrary exception during execution. Observed a helpful message on the client with no additional steps.

Diff Detail

Repository
rP Phabricator
Branch
hg2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19013
Build 25647: Run Core Tests
Build 25646: arc lint + arc unit