Page MenuHomePhabricator
Differential D18805

Make bulk editor working set editable and more homogenous
ClosedPublic
Actions

Authored by epriestley on Nov 30 2017, 1:39 PM.
Tags
None
Referenced Files
F13087899: D18805.diff
Thu, Apr 25, 1:10 AM
F13081248: D18805.diff
Wed, Apr 24, 4:40 PM
Unknown Object (File)
Fri, Apr 19, 2:43 AM
Unknown Object (File)
Wed, Apr 17, 2:45 PM
Unknown Object (File)
Thu, Apr 4, 2:17 AM
Unknown Object (File)
Wed, Apr 3, 9:51 AM
Unknown Object (File)
Sun, Mar 31, 11:08 PM
Unknown Object (File)
Thu, Mar 28, 5:52 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T10005: Implement an ApplicationEditor-based Bulk Editor
T11286: make it possible to remove tasks from a batch edit tasks workflow
T13025: Turn bulk editor into a generic piece of EditEngine infrastructure with Custom Field support
Commits
rPad659627b3e9: Make bulk editor working set editable and more homogenous
Summary

Ref T13025. See PHI50. Fixes T11286. Ref T10005. Begin modernizing the bulk editor.

For T10005 ("move the bulk editor to modern infrastructure"), rewrite the rendering of the editable set so that it is application-agnostic and can work with any kind of object.

For T11286 ("let users de-select items in the working set"), make the working set editable.

Test Plan

Screen Shot 2017-11-30 at 5.34.28 AM.png (1×1 px, 140 KB)

  • Deselected some objects, applied an edit, saw the edit apply to only selected objects.

Diff Detail

Repository
rP Phabricator
Branch
bulk1
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningwebroot/rsrc/js/phui/behavior-phui-selectable-list.js:1JAVELIN5`javelinsymbols` Not In Path
Unit
Tests Passed
Build Status
Buildable 18912
Build 25503: Run Core Tests
Build 25502: arc lint + arc unit

Event Timeline

epriestley created this revision.Nov 30 2017, 1:39 PM
epriestley requested review of this revision.Nov 30 2017, 3:28 PM
epriestley added a child revision: D18806: Rebuild the bulk editor on SearchEngine.
amckinley accepted this revision.Nov 30 2017, 10:59 PM

New interface looks great!

webroot/rsrc/js/phui/behavior-phui-selectable-list.js
24

"selection"

This revision is now accepted and ready to land.Nov 30 2017, 10:59 PM
epriestley updated this revision to Diff 45139.Nov 30 2017, 11:18 PM
  • Spelling fix.
Closed by commit rPad659627b3e9: Make bulk editor working set editable and more homogenous (authored by epriestley). · Explain WhyJan 19 2018, 8:39 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
17 lines
src/
applications/
maniphest/
controller/
77 lines
view/
phui/
43 lines
webroot/
rsrc/
css/
phui/
object-item/
19 lines
4 lines
js/
phui/
44 lines

Diff 45139

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/maniphest/controller/ManiphestBatchEditController.php

Loading...
View Options

src/view/phui/PHUIObjectItemView.php

Loading...
View Options

webroot/rsrc/css/phui/object-item/phui-oi-list-view.css

Loading...
View Options

webroot/rsrc/css/phui/phui-box.css

Loading...
View Options

webroot/rsrc/js/phui/behavior-phui-selectable-list.js

Loading...
Phabricator · Built by Phacility