Page MenuHomePhabricator

Improve PHP7 error reporting for include-time syntax errors
ClosedPublic

Authored by epriestley on Nov 28 2017, 2:05 PM.
Tags
None
Referenced Files
F14171499: D18797.diff
Sat, Dec 7, 11:48 PM
Unknown Object (File)
Thu, Dec 5, 12:02 PM
Unknown Object (File)
Tue, Dec 3, 8:50 AM
Unknown Object (File)
Tue, Dec 3, 3:30 AM
Unknown Object (File)
Thu, Nov 28, 4:25 AM
Unknown Object (File)
Sun, Nov 24, 3:00 AM
Unknown Object (File)
Fri, Nov 8, 5:26 AM
Unknown Object (File)
Fri, Nov 8, 5:13 AM
Subscribers
None

Details

Summary

Ref T12101. Ref T12855. Ref T12190.

In PHP7, include_once may raise a Throwable which has a useless message and stack trace (neither point at the actual file or line where the error occurs).

Catch and mangle these so they're useful. This upgrades the message from syntax error: unexpected X so it has a file and line number.

Test Plan

Screen Shot 2017-11-28 at 6.03.12 AM.png (1×1 px, 220 KB)

Diff Detail

Repository
rPHU libphutil
Branch
throw1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18872
Build 25446: Run Core Tests
Build 25445: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Nov 28 2017, 5:54 PM

The specific error / reproduction case here was something like $this->someMethod(): (instead of ...();) if that's helpful to some future archaeologist.

This revision was automatically updated to reflect the committed changes.