Improve PHP7 error reporting for include-time syntax errors
ClosedPublic
Actions

Authored by epriestley on Nov 28 2017, 2:05 PM.

Details

Reviewers

Maniphest Tasks

T12101: Phabricator PHP 7 Compatibility
T12190: In PHP7, include-time warnings from source files are ignored
T12855: In PHP7, "Throwable" and "Error" are exciting new exception classes

Commits

rPHU3c07eb08b2a7: Improve PHP7 error reporting for include-time syntax errors

Summary

Ref T12101. Ref T12855. Ref T12190.

In PHP7, include_once may raise a Throwable which has a useless message and stack trace (neither point at the actual file or line where the error occurs).

Catch and mangle these so they're useful. This upgrades the message from syntax error: unexpected X so it has a file and line number.

Test Plan

Screen Shot 2017-11-28 at 6.03.12 AM.png (1×1 px, 220 KB)

Diff Detail

Repository

rPHU libphutil

Branch

throw1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 18872
Build 25446: Run Core Tests
Build 25445: arc lint + arc unit

Event Timeline

epriestley created this revision.Nov 28 2017, 2:05 PM

Harbormaster completed remote builds in B18872: Diff 45091.Nov 28 2017, 2:05 PM

epriestley requested review of this revision.Nov 28 2017, 2:05 PM

amckinley accepted this revision.Nov 28 2017, 5:54 PM

This revision is now accepted and ready to land.Nov 28 2017, 5:54 PM

The specific error / reproduction case here was something like $this->someMethod(): (instead of ...();) if that's helpful to some future archaeologist.

Closed by commit rPHU3c07eb08b2a7: Improve PHP7 error reporting for include-time syntax errors (authored by epriestley). · Explain WhyNov 28 2017, 6:54 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in D18809: Mark `ParseError` as a PHP7 builtin class.Nov 30 2017, 7:28 PM

epriestley mentioned this in rPHU59642f236822: Mark `ParseError` as a PHP7 builtin class.Nov 30 2017, 7:30 PM