Page MenuHomePhabricator

Mark `ParseError` as a PHP7 builtin class
ClosedPublic

Authored by epriestley on Nov 30 2017, 7:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 23, 11:21 PM
Unknown Object (File)
Jan 21 2025, 11:20 AM
Unknown Object (File)
Jan 14 2025, 1:51 PM
Unknown Object (File)
Dec 31 2024, 4:22 AM
Unknown Object (File)
Dec 27 2024, 3:05 PM
Unknown Object (File)
Dec 24 2024, 1:55 PM
Unknown Object (File)
Dec 19 2024, 7:55 AM
Unknown Object (File)
Dec 17 2024, 7:42 AM
Subscribers

Details

Summary

Ref T12855. In D18797, I introduced a catch (ParseError ...) to deal with a PHP7 special case. However, this class won't exist in earlier versions of PHP like PHP5.

@lpriestley reports hitting an error with this under PHP5 ("unknown class/interface ParseError") from the linter while running arc diff, which is expected since I didn't add it to the secret list of special PHP7 magic.

Add it to the PHP7 magic.

(It's fine that we catch something which may not exist in PHP5, since Throwable does not exist in PHP5 and the catch (Exception ...) above will catch everything which can be caught in PHP5.)

Test Plan

Will make @lpriestley try again.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable