Page MenuHomePhabricator

Mark `ParseError` as a PHP7 builtin class
ClosedPublic

Authored by epriestley on Nov 30 2017, 7:28 PM.
Tags
None
Referenced Files
F15843899: D18809.id45129.diff
Sat, May 31, 2:02 AM
Unknown Object (File)
Fri, May 30, 8:30 AM
Unknown Object (File)
Thu, May 29, 5:48 PM
Unknown Object (File)
Mon, May 5, 11:34 PM
Unknown Object (File)
Apr 29 2025, 1:10 AM
Unknown Object (File)
Apr 27 2025, 11:38 PM
Unknown Object (File)
Apr 24 2025, 8:41 AM
Unknown Object (File)
Apr 23 2025, 6:26 PM
Subscribers

Details

Summary

Ref T12855. In D18797, I introduced a catch (ParseError ...) to deal with a PHP7 special case. However, this class won't exist in earlier versions of PHP like PHP5.

@lpriestley reports hitting an error with this under PHP5 ("unknown class/interface ParseError") from the linter while running arc diff, which is expected since I didn't add it to the secret list of special PHP7 magic.

Add it to the PHP7 magic.

(It's fine that we catch something which may not exist in PHP5, since Throwable does not exist in PHP5 and the catch (Exception ...) above will catch everything which can be caught in PHP5.)

Test Plan

Will make @lpriestley try again.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable