Page MenuHomePhabricator

Improve PHP7 error reporting for include-time syntax errors
ClosedPublic

Authored by epriestley on Nov 28 2017, 2:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jun 25, 10:46 PM
Unknown Object (File)
Thu, Jun 23, 11:11 PM
Unknown Object (File)
Wed, Jun 22, 3:06 PM
Unknown Object (File)
Tue, Jun 21, 6:45 PM
Unknown Object (File)
Mon, Jun 20, 10:20 PM
Unknown Object (File)
Sat, Jun 18, 5:36 PM
F5298590: Screen Shot 2017-11-28 at 6.03.12 AM.png
Nov 28 2017, 2:05 PM
Subscribers
None

Details

Summary

Ref T12101. Ref T12855. Ref T12190.

In PHP7, include_once may raise a Throwable which has a useless message and stack trace (neither point at the actual file or line where the error occurs).

Catch and mangle these so they're useful. This upgrades the message from syntax error: unexpected X so it has a file and line number.

Test Plan

Screen Shot 2017-11-28 at 6.03.12 AM.png (1×1 px, 220 KB)

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Nov 28 2017, 5:54 PM

The specific error / reproduction case here was something like $this->someMethod(): (instead of ...();) if that's helpful to some future archaeologist.

This revision was automatically updated to reflect the committed changes.