Paths

Table of Contentst

Differential D18742

If possible, use "differential.revision.edit" in "arc diff"
ClosedPublic
Actions

Authored by epriestley on Oct 27 2017, 5:04 PM.

Details

Reviewers

amckinley

Commits

rARC98cc64302ef6: If possible, use "differential.revision.edit" in "arc diff"

Summary

Depends on D18741. Switches to "differential.revision.edit" if we get a transaction list back from parsing (added by D18740).

This will allow us to use new transactions, notably "Hold as Draft" for "--draft".

Test Plan

Ran arc diff, got a revision via differential.revision.edit.

Diff Detail

Repository

rARC Arcanist

Branch

draft6

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/workflow/ArcanistDiffWorkflow.php:554	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 18761
Build 25283: Run Core Tests
Build 25282: arc lint + arc unit

Event Timeline

epriestley created this revision.Oct 27 2017, 5:04 PM

Harbormaster completed remote builds in B18761: Diff 44981.Oct 27 2017, 5:05 PM

epriestley requested review of this revision.Oct 27 2017, 5:05 PM

epriestley added a child revision: D18743: Add "arc diff --draft".Oct 27 2017, 5:24 PM

amckinley accepted this revision.Oct 28 2017, 3:31 PM

This revision is now accepted and ready to land.Oct 28 2017, 3:31 PM

Closed by commit rARC98cc64302ef6: If possible, use "differential.revision.edit" in "arc diff" (authored by epriestley). · Explain WhyOct 30 2017, 10:19 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

differential/

ArcanistDifferentialCommitMessage.php

8 lines

workflow/

ArcanistDiffWorkflow.php

51 lines

Diff 44981

View Options

src/differential/ArcanistDifferentialCommitMessage.php