Ref T2543. Instead of autosubmitting revisions to "Needs Review" when builds finish, allow them to be held in "Draft" indefinitely.
There's currently no UI for this. I plan to just expose it as arc diff --draft for now, in a followup change.
Details
Details
- Created a revision (via Conduit) with "hold as draft", saw it hold as draft after builds finished.
- Created a revision (normally), saw it autosubmit after builds finished.
- Requested review of a "hold as draft" revision to kick it out of draft state.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- draft1
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 18755 Build 25272: Run Core Tests Build 25271: arc lint + arc unit
Event Timeline
| src/applications/differential/storage/DifferentialRevision.php | ||
|---|---|---|
| 716 | Unused argument. Should be return $this->setProperty(self::PROPERTY_DRAFT_HOLD, $hold);? | |