Page MenuHomePhabricator

Fix transaction queries using withComments() for transactions with no comments
ClosedPublic

Authored by epriestley on Oct 2 2017, 2:24 PM.
Tags
None
Referenced Files
F14804875: D18667.diff
Sat, Jan 25, 6:33 PM
F14791891: D18667.id44818.diff
Fri, Jan 24, 10:39 PM
Unknown Object (File)
Fri, Jan 24, 3:09 AM
Unknown Object (File)
Sun, Jan 19, 5:50 PM
Unknown Object (File)
Sun, Jan 19, 10:10 AM
Unknown Object (File)
Thu, Jan 9, 6:51 PM
Unknown Object (File)
Dec 22 2024, 7:32 AM
Unknown Object (File)
Dec 6 2024, 12:49 AM
Subscribers
None

Details

Summary

See https://discourse.phabricator-community.org/t/daemons-tasks-crashing-in-a-loop-during-reindex/506/1. Some object types (for example, Passphrase Credentials) support indexing but not commenting.

Make withComments(...) work properly if the transaction type does not support comments.

Test Plan

Indexed a credential (no comments) and a revision (comments) with bin/search index --trace ....

Before, credential fataled.

After, credetial succeeds, and skips the transaction query.

Before and after, the revision queries the transaction table.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable