Paths

Table of Contentst

Differential D18667

Fix transaction queries using withComments() for transactions with no comments
ClosedPublic
Actions

Authored by epriestley on Oct 2 2017, 2:24 PM.

Tags

None

Referenced Files

	F18083748: D18667.diff
	Tue, Aug 5, 11:18 AM

	F18082236: D18667.id44818.diff
	Tue, Aug 5, 4:47 AM

	F18053321: D18667.id.diff
	Mon, Aug 4, 4:31 AM

	F17949438: D18667.id44819.diff
	Thu, Jul 31, 11:25 PM

	Unknown Object (File)
	Jul 4 2025, 12:01 PM

	Unknown Object (File)
	Jul 3 2025, 7:05 PM

	Unknown Object (File)
	Jun 2 2025, 6:12 PM

	Unknown Object (File)
	May 10 2025, 11:39 PM

Subscribers

None

Details

Reviewers

Commits

rP8297f7a18288: (stable) Fix transaction queries using withComments() for transactions with no…
rPcd14194a3297: Fix transaction queries using withComments() for transactions with no comments

Summary

See https://discourse.phabricator-community.org/t/daemons-tasks-crashing-in-a-loop-during-reindex/506/1. Some object types (for example, Passphrase Credentials) support indexing but not commenting.

Make withComments(...) work properly if the transaction type does not support comments.

Test Plan

Indexed a credential (no comments) and a revision (comments) with bin/search index --trace ....

Before, credential fataled.

After, credetial succeeds, and skips the transaction query.

Before and after, the revision queries the transaction table.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Oct 2 2017, 2:24 PM

Harbormaster completed remote builds in B18598: Diff 44818.Oct 2 2017, 2:25 PM

amckinley accepted this revision.Oct 2 2017, 3:31 PM

This revision is now accepted and ready to land.Oct 2 2017, 3:31 PM

Closed by commit rPcd14194a3297: Fix transaction queries using withComments() for transactions with no comments (authored by epriestley). · Explain WhyOct 2 2017, 4:09 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

query/

PhabricatorApplicationTransactionQuery.php

31 lines

Diff 44819

src/applications/transactions/query/PhabricatorApplicationTransactionQuery.php

Loading...