Fix transaction queries using withComments() for transactions with no comments
ClosedPublic
Actions

Authored by epriestley on Oct 2 2017, 2:24 PM.

Details

Reviewers

Commits

rP8297f7a18288: (stable) Fix transaction queries using withComments() for transactions with no…
rPcd14194a3297: Fix transaction queries using withComments() for transactions with no comments

Summary

See https://discourse.phabricator-community.org/t/daemons-tasks-crashing-in-a-loop-during-reindex/506/1. Some object types (for example, Passphrase Credentials) support indexing but not commenting.

Make withComments(...) work properly if the transaction type does not support comments.

Test Plan

Indexed a credential (no comments) and a revision (comments) with bin/search index --trace ....

Before, credential fataled.

After, credetial succeeds, and skips the transaction query.

Before and after, the revision queries the transaction table.

Diff Detail

Repository

rP Phabricator

Branch

comment1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 18598
Build 25052: Run Core Tests
Build 25051: arc lint + arc unit

Event Timeline

epriestley created this revision.Oct 2 2017, 2:24 PM

Harbormaster completed remote builds in B18598: Diff 44818.Oct 2 2017, 2:25 PM

amckinley accepted this revision.Oct 2 2017, 3:31 PM

This revision is now accepted and ready to land.Oct 2 2017, 3:31 PM

Closed by commit rPcd14194a3297: Fix transaction queries using withComments() for transactions with no comments (authored by epriestley). · Explain WhyOct 2 2017, 4:09 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

query/

PhabricatorApplicationTransactionQuery.php

31 lines

Diff 44818

View Options

src/applications/transactions/query/PhabricatorApplicationTransactionQuery.php

Fix transaction queries using withComments() for transactions with no commentsClosedPublicActions