Page MenuHomePhabricator
Differential D18666

Fix an exception in the hyperlink remarkup rule for unparseable URIs
ClosedPublic
Actions

Authored by epriestley on Oct 2 2017, 2:14 PM.
Tags
None
Referenced Files
F19076505: D18666.id.diff
Mon, Dec 1, 12:18 PM
F19070918: D18666.diff
Sun, Nov 30, 6:11 PM
F18872295: D18666.id44817.diff
Wed, Nov 5, 3:28 AM
F18872291: D18666.id44820.diff
Wed, Nov 5, 3:28 AM
F18869344: D18666.diff
Tue, Nov 4, 11:16 AM
F18852816: D18666.id.diff
Oct 31 2025, 12:17 PM
F18850639: D18666.diff
Oct 30 2025, 6:24 PM
F18755555: D18666.diff
Oct 5 2025, 6:12 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T12526: parse_url() behavior has changed with PHP7, causing libphutil unit tests to fail and possibly creating security concerns
Commits
rPHUf7b0855acf5a: (stable) Fix an exception in the hyperlink remarkup rule for unparseable URIs
rPHU20db87e17679: Fix an exception in the hyperlink remarkup rule for unparseable URIs
Summary

Ref T12526. URIs in the form http://x.y/#http://x.y/# can fail to parse. Catch these cases and ignore them, rather than throwing.

See also similar changes earlier, in D18149 and D18076.

Test Plan
  • Added failing test cases, made them pass.

Screen Shot 2017-10-02 at 7.14.34 AM.png (569×385 px, 33 KB)

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
markup/
engine/
__tests__/
remarkup/
5 lines
5 lines
remarkup/
markuprule/
15 lines

Diff 44820

View Options

src/markup/engine/__tests__/remarkup/link-with-angle-link-anchor.txt

Loading...
View Options

src/markup/engine/__tests__/remarkup/link-with-link-anchor.txt

Loading...
View Options

src/markup/engine/remarkup/markuprule/PhutilRemarkupHyperlinkRule.php

Loading...
Phabricator · Built by Phacility