Page MenuHomePhabricator

Fix an exception in the hyperlink remarkup rule for unparseable URIs
ClosedPublic

Authored by epriestley on Oct 2 2017, 2:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 13, 7:17 PM
Unknown Object (File)
Sun, Mar 10, 6:31 PM
Unknown Object (File)
Feb 26 2024, 5:58 AM
Unknown Object (File)
Feb 18 2024, 1:43 AM
Unknown Object (File)
Feb 17 2024, 9:41 PM
Unknown Object (File)
Dec 21 2023, 9:55 PM
Unknown Object (File)
Dec 19 2023, 9:45 PM
Unknown Object (File)
Dec 17 2023, 6:30 AM
Subscribers
None

Details

Summary

Ref T12526. URIs in the form http://x.y/#http://x.y/# can fail to parse. Catch these cases and ignore them, rather than throwing.

See also similar changes earlier, in D18149 and D18076.

Test Plan
  • Added failing test cases, made them pass.

Screen Shot 2017-10-02 at 7.14.34 AM.png (569×385 px, 33 KB)

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable