Page MenuHomePhabricator

Fix an exception in the hyperlink remarkup rule for unparseable URIs
ClosedPublic

Authored by epriestley on Oct 2 2017, 2:14 PM.
Tags
None
Referenced Files
F17927218: D18666.id.diff
Wed, Jul 30, 2:19 PM
F17913434: D18666.diff
Tue, Jul 29, 5:51 PM
Unknown Object (File)
Jun 16 2025, 8:12 PM
Unknown Object (File)
Jun 16 2025, 8:12 PM
Unknown Object (File)
Jun 16 2025, 8:10 PM
Unknown Object (File)
Jun 16 2025, 7:17 PM
Unknown Object (File)
Jun 1 2025, 5:42 AM
Unknown Object (File)
May 26 2025, 5:44 PM
Subscribers
None

Details

Summary

Ref T12526. URIs in the form http://x.y/#http://x.y/# can fail to parse. Catch these cases and ignore them, rather than throwing.

See also similar changes earlier, in D18149 and D18076.

Test Plan
  • Added failing test cases, made them pass.

Screen Shot 2017-10-02 at 7.14.34 AM.png (569×385 px, 33 KB)

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable