Differential D18665

Rough cut of "Move tasks to column..."
ClosedPublic
Actions

Authored by epriestley on Sep 29 2017, 11:24 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T5523: Make bulk moves easier on Workboards

Commits

rP5c73c169fd31: Rough cut of "Move tasks to column..."

Summary

Ref T5523. See PHI50. See PHI40. This isn't perfect, but should improve things.

Add a "Move tasks to column..." action to workboards which moves all visible tasks in a column to another column, either on the same board or on a different board.

This is a two-step process so that I don't have to write Javascript, and because I'm not 100% sure this is what users actually want/need. If it sticks, the UI could be refined later.

The first dialog asks you to choose a project, defaulting ot the current project.
The second dialog asks you to choose a column on that project's board.

Test Plan

Moved tasks on the same board.
Moved tasks to a different board.
Tried to move tasks to the starting column, got a sensible error.
Tried to move tasks to no project, got a sensible error.

Diff Detail

Repository

rP Phabricator

Branch

move1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 18593
Build 25045: Run Core Tests
Build 25044: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 29 2017, 11:24 PM

No surprises here, but this is what it looks like in the UI:

Screen Shot 2017-09-29 at 4.24.46 PM.png (307×363 px, 31 KB)

Harbormaster completed remote builds in B18592: Diff 44813.Sep 29 2017, 11:25 PM

Whoooo this is going to blow people's MINDS.

parrot parrot parrot

src/applications/project/controller/PhabricatorProjectBoardViewController.php
324	/s/a valid/an existing/
1053	Maybe "Move Tasks to Different Project/Column..." to make it clear that you have more targets than you can currently see?

This revision is now accepted and ready to land.Sep 30 2017, 12:28 AM

amckinley mentioned this in T12998: Image macros not working in Differential.Sep 30 2017, 12:32 AM

epriestley added inline comments.Sep 30 2017, 12:36 AM

src/applications/project/controller/PhabricatorProjectBoardViewController.php
324	The bad value could be an existing column, just on a different board. (Users probably can't hit this anyway without editing the HTML source.)
1053	One possible point of confusion with that phrasing is that you can't move them to a project unless that project has a workboard -- i.e., you must target a column. I'm also still not entirely sure what the use cases are here, it's possible that almost no one (i.e., only one user) actually cares about moving things to a column on another board, so maybe this shouldn't actually offer the "project" mode, or we should bury that somewhere in advanced/secret options. I'm inclined to leave this as is for the moment and see if there's actual confusion since my gut is that most users just care about "move to column".

Wordsmithing to make "valid" / "existent" more clear: "valid column on target workboard".

We could also go the other direction and let you pick a project with no workboard, then prompt you "That project has no board, are you sure?".

I'm also not sure if we should send you to the target board at the end of this, vs keeping you in the same place. Maybe moot if most moves are on the same board. I kept you in the same place for now, mostly because it's easier.

Harbormaster completed remote builds in B18593: Diff 44814.Sep 30 2017, 12:38 AM

Closed by commit rP5c73c169fd31: Rough cut of "Move tasks to column..." (authored by epriestley). · Explain WhySep 30 2017, 12:38 AM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T5523: Make bulk moves easier on Workboards.Feb 13 2018, 11:43 PM