Fixes T12792. Expands the Notifications to "web, desktop, both, or none" for real-time notifications in settings.
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T12792: Consider an option to disable all popup notifications
- Commits
- rP63bd1784b08c: Allow more granularity on real-time notifications
Test with "test notifications" button, and while logged into two accounts with each of the 4 settings.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- notifications (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 18130 Build 24367: Run Core Tests Build 24366: arc lint + arc unit
Event Timeline
Comment Actions
This will also hide some other notifications (like the timezone notification, and the MFA notification, and the read-only mode notification) but currently none are critical. We could make those notifications punch through this setting eventually.
Comment Actions
Yeah, users who want to turn this off (???) probably won't mind that we turned all the "important system notifications" off too.
Comment Actions
I'd like to figure out how to get rid of Timezone stuff. It's been annoying to me, then again I've launched like 50 new installs in the past few weeks testing. System messages maybe should be done another way.