Page MenuHomePhabricator

Modernize FeedSearchEngine a little bit
ClosedPublic

Authored by epriestley on May 26 2017, 5:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 20, 10:45 PM
Unknown Object (File)
Feb 18 2024, 12:07 PM
Unknown Object (File)
Feb 12 2024, 6:27 AM
Unknown Object (File)
Jan 5 2024, 4:56 AM
Unknown Object (File)
Dec 27 2023, 11:16 AM
Unknown Object (File)
Dec 27 2023, 11:16 AM
Unknown Object (File)
Dec 27 2023, 11:16 AM
Unknown Object (File)
Dec 27 2023, 11:16 AM
Subscribers
None

Details

Summary

Ref T12762. This updates FeedSeachEngine to user modern construction.

I've tried to retain behavior exactly, although the "Include stories about projects I'm a member of" checkbox is now nonstandard/obsolete. We could likely fold that into "Include Projects" in a future change which does a backward compatibility break.

Test Plan
  • Queried feed without constraints.
  • Queried feed by user, project, "stuff I'm a member of", prebuilt "Tags" query.
  • Viewed user profile / project profile feeds.
  • Used function tokens (viewer(), etc).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.May 26 2017, 5:34 PM
  • Use a slightly less fancy project selector, since some of the advanced options do not work because this is not a real EdgeLogic query.
This revision was automatically updated to reflect the committed changes.