Page MenuHomePhabricator

Modernize FeedSearchEngine a little bit
ClosedPublic

Authored by epriestley on May 26 2017, 5:11 PM.
Tags
None
Referenced Files
F15360555: D18028.id43363.diff
Tue, Mar 11, 9:02 AM
F15333437: D18028.id43363.diff
Sat, Mar 8, 2:22 AM
F15333268: D18028.diff
Sat, Mar 8, 1:31 AM
Unknown Object (File)
Feb 16 2025, 2:59 PM
Unknown Object (File)
Feb 6 2025, 2:53 PM
Unknown Object (File)
Feb 2 2025, 1:40 AM
Unknown Object (File)
Feb 1 2025, 5:21 PM
Unknown Object (File)
Jan 30 2025, 6:18 AM
Subscribers
None

Details

Summary

Ref T12762. This updates FeedSeachEngine to user modern construction.

I've tried to retain behavior exactly, although the "Include stories about projects I'm a member of" checkbox is now nonstandard/obsolete. We could likely fold that into "Include Projects" in a future change which does a backward compatibility break.

Test Plan
  • Queried feed without constraints.
  • Queried feed by user, project, "stuff I'm a member of", prebuilt "Tags" query.
  • Viewed user profile / project profile feeds.
  • Used function tokens (viewer(), etc).

Diff Detail

Repository
rP Phabricator
Branch
feed2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17271
Build 23133: Run Core Tests
Build 23132: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.May 26 2017, 5:34 PM
  • Use a slightly less fancy project selector, since some of the advanced options do not work because this is not a real EdgeLogic query.
This revision was automatically updated to reflect the committed changes.