Paths

Table of Contentst

Differential D18028

Modernize FeedSearchEngine a little bit
ClosedPublic
Actions

Authored by epriestley on May 26 2017, 5:11 PM.

Tags

None

Referenced Files

	F15456671: D18028.id43360.diff
	Sun, Mar 30, 11:15 AM

	F15451421: D18028.id.diff
	Fri, Mar 28, 10:00 PM

	F15451105: D18028.id43369.diff
	Fri, Mar 28, 8:09 PM

	F15450357: D18028.id43363.diff
	Fri, Mar 28, 3:13 PM

	F15441996: D18028.diff
	Wed, Mar 26, 8:55 PM

	F15424567: D18028.diff
	Sat, Mar 22, 11:03 PM

	F15419604: D18028.id43363.diff
	Fri, Mar 21, 7:18 AM

	F15360555: D18028.id43363.diff
	Tue, Mar 11, 9:02 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T12762: Feed queries should support date range constraints

Commits

rP6fed08a98e04: Modernize FeedSearchEngine a little bit

Summary

Ref T12762. This updates FeedSeachEngine to user modern construction.

I've tried to retain behavior exactly, although the "Include stories about projects I'm a member of" checkbox is now nonstandard/obsolete. We could likely fold that into "Include Projects" in a future change which does a backward compatibility break.

Test Plan

Queried feed without constraints.
Queried feed by user, project, "stuff I'm a member of", prebuilt "Tags" query.
Viewed user profile / project profile feeds.
Used function tokens (viewer(), etc).

Diff Detail

Repository

Branch

feed2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 17271
Build 23133: Run Core Tests
Build 23132: arc lint + arc unit

Event Timeline

epriestley created this revision.May 26 2017, 5:11 PM

Harbormaster completed remote builds in B17271: Diff 43360.May 26 2017, 5:12 PM

chad accepted this revision.May 26 2017, 5:34 PM

This revision is now accepted and ready to land.May 26 2017, 5:34 PM

Use a slightly less fancy project selector, since some of the advanced options do not work because this is not a real EdgeLogic query.

Harbormaster completed remote builds in B17274: Diff 43363.May 26 2017, 5:36 PM

Closed by commit rP6fed08a98e04: Modernize FeedSearchEngine a little bit (authored by epriestley, committed by epriestley). · Explain WhyMay 26 2017, 7:22 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T12851: The feed query '2HfUlTnoqZbw' causes an exception in PhabricatorSearchCheckboxesField.Jun 19 2017, 5:04 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

feed/

query/

PhabricatorFeedQuery.php

14 lines

PhabricatorFeedSearchEngine.php

93 lines

Diff 43360

src/applications/feed/query/PhabricatorFeedQuery.php

Loading...

src/applications/feed/query/PhabricatorFeedSearchEngine.php

Loading...