When the Differential filetree is toggled, resize the keyboard reticle properly
ClosedPublic
Actions

Authored by epriestley on May 16 2017, 2:01 PM.

Details

Reviewers

Maniphest Tasks

T9270: Toggling File Browser on Differential while creating inline comment causes inline/edit focus reticle to offset
T12634: Keyboard focus reticle is generally oblivious to the world around it

Commits

rP3c0da8161967: When the Differential filetree is toggled, resize the keyboard reticle properly

Summary

Ref T9270. Ref T12634. Emit a resize event after toggling the filetree so that things can recalculate layout.

This just does the keyboard reticle, not the mouse/edit reticle.

Test Plan

Used "n" to select a block.
Used "f" to toggle the filetree.
Saw reticle resize properly.

Diff Detail

Repository

rP Phabricator

Branch

focus4

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16989
Build 22711: Run Core Tests
Build 22710: arc lint + arc unit

Event Timeline

epriestley created this revision.May 16 2017, 2:01 PM

Harbormaster completed remote builds in B16989: Diff 43061.May 16 2017, 2:02 PM

chad accepted this revision.May 16 2017, 2:23 PM

This revision is now accepted and ready to land.May 16 2017, 2:23 PM

Closed by commit rP3c0da8161967: When the Differential filetree is toggled, resize the keyboard reticle properly (authored by epriestley, committed by epriestley). · Explain WhyMay 16 2017, 3:22 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

32 lines

webroot/

rsrc/

js/

core/

behavior-phabricator-nav.js

4 lines

Diff 43061

View Options

resources/celerity/map.php