Page MenuHomePhabricator

In Applications, always redirect back to the detail page after edits
ClosedPublic

Authored by epriestley on May 14 2017, 8:42 PM.
Tags
None
Referenced Files
F17948089: D17877.id43003.diff
Thu, Jul 31, 7:59 PM
F17947568: D17877.id.diff
Thu, Jul 31, 5:22 PM
F17895784: D17877.diff
Tue, Jul 29, 6:32 AM
Unknown Object (File)
Jun 1 2025, 6:01 PM
Unknown Object (File)
May 30 2025, 4:46 AM
Unknown Object (File)
Apr 29 2025, 3:03 PM
Unknown Object (File)
Apr 28 2025, 4:28 AM
Unknown Object (File)
Apr 21 2025, 4:56 PM
Subscribers
None

Details

Summary

Ref T12685. When you edit an application's policies but don't make any changes, you currently get stuck on the same page. This isn't how other edit screens work, and I think it's a holdover from eras long ago.

Make it consistent with other applications.

Also, fix a missing pht().

Test Plan
  • Edited an application configuation.
  • Clicked "Save" without making changes.
  • After patch, was redirected back to detail page like in other applications.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.May 14 2017, 8:43 PM
This revision was automatically updated to reflect the committed changes.