diff --git a/src/applications/meta/controller/PhabricatorApplicationEditController.php b/src/applications/meta/controller/PhabricatorApplicationEditController.php --- a/src/applications/meta/controller/PhabricatorApplicationEditController.php +++ b/src/applications/meta/controller/PhabricatorApplicationEditController.php @@ -32,7 +32,6 @@ if ($request->isFormPost()) { $xactions = array(); - $result = array(); $template = $application->getApplicationTransactionTemplate(); foreach ($application->getCapabilities() as $capability) { if (!$application->isCapabilityEditable($capability)) { @@ -47,8 +46,6 @@ continue; } - $result[$capability] = $new; - $xactions[] = id(clone $template) ->setTransactionType( PhabricatorApplicationPolicyChangeTransaction::TRANSACTIONTYPE) @@ -58,25 +55,23 @@ ->setNewValue($new); } - if ($result) { - $editor = id(new PhabricatorApplicationEditor()) - ->setActor($user) - ->setContentSourceFromRequest($request) - ->setContinueOnNoEffect(true) - ->setContinueOnMissingFields(true); - - try { - $editor->applyTransactions($application, $xactions); - return id(new AphrontRedirectResponse())->setURI($view_uri); - } catch (PhabricatorApplicationTransactionValidationException $ex) { - $validation_exception = $ex; - } - - return $this->newDialog() - ->setTitle('Validation Failed') - ->setValidationException($validation_exception) - ->addCancelButton($view_uri); + $editor = id(new PhabricatorApplicationEditor()) + ->setActor($user) + ->setContentSourceFromRequest($request) + ->setContinueOnNoEffect(true) + ->setContinueOnMissingFields(true); + + try { + $editor->applyTransactions($application, $xactions); + return id(new AphrontRedirectResponse())->setURI($view_uri); + } catch (PhabricatorApplicationTransactionValidationException $ex) { + $validation_exception = $ex; } + + return $this->newDialog() + ->setTitle(pht('Validation Failed')) + ->setValidationException($validation_exception) + ->addCancelButton($view_uri); } $descriptions = PhabricatorPolicyQuery::renderPolicyDescriptions(