Page MenuHomePhabricator

In Applications, always redirect back to the detail page after edits
ClosedPublic

Authored by epriestley on May 14 2017, 8:42 PM.
Tags
None
Referenced Files
F13159781: D17877.diff
Mon, May 6, 2:45 AM
F13159020: D17877.diff
Sun, May 5, 10:50 PM
Unknown Object (File)
Wed, May 1, 8:16 PM
Unknown Object (File)
Mon, Apr 22, 11:41 AM
Unknown Object (File)
Fri, Apr 19, 6:29 PM
Unknown Object (File)
Mon, Apr 8, 7:46 PM
Unknown Object (File)
Sun, Apr 7, 7:51 PM
Unknown Object (File)
Apr 3 2024, 5:04 PM
Subscribers
None

Details

Summary

Ref T12685. When you edit an application's policies but don't make any changes, you currently get stuck on the same page. This isn't how other edit screens work, and I think it's a holdover from eras long ago.

Make it consistent with other applications.

Also, fix a missing pht().

Test Plan
  • Edited an application configuation.
  • Clicked "Save" without making changes.
  • After patch, was redirected back to detail page like in other applications.

Diff Detail

Repository
rP Phabricator
Branch
err3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16921
Build 22611: Run Core Tests
Build 22610: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.May 14 2017, 8:43 PM
This revision was automatically updated to reflect the committed changes.