Page MenuHomePhabricator

Improve `ArcanistLinterStandardTestCase`
Needs ReviewPublic

Authored by wjiang on Apr 24 2017, 1:04 AM.

Details

Summary

Ref T12631. Let unit test actually test ArcanistLinterStandard.

Test Plan

Run unit test

Diff Detail

Repository
rARC Arcanist
Branch
arcpatch-D17783
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 16794
Build 22413: arc lint + arc unit

Event Timeline

wjiang created this revision.Apr 24 2017, 1:04 AM
wjiang edited the test plan for this revision. (Show Details)Apr 24 2017, 1:05 AM
wjiang updated this revision to Diff 42759.Apr 24 2017, 1:10 AM

Add final

joshuaspence accepted this revision.May 4 2017, 12:01 AM
joshuaspence added a subscriber: joshuaspence.

LGTM. @epriestley, it would be greatly appreciated if this could be accepted upstream. We have a large number of XHPAST linter rules (I think ~200) and we want to write integration tests to ensure that they play nicely together.

src/lint/linter/standards/__tests__/ArcanistLinterStandardTestCase.php
4

You should extend ArcanistLinterTestCase instead

5–8

You might want to leave this.

8

Maybe call this getBaseLinter?

10

I think this should be called getStandard

15–18

Ideally, we should have some sort of $linter->applyStandard($standard) method... because this code is currently duplicated from ArcanistLinter

wjiang updated this revision to Diff 42867.May 4 2017, 12:52 AM
wjiang marked 5 inline comments as done.
  • Add applyStandard
wjiang updated this revision to Diff 42868.May 4 2017, 12:54 AM
  • Minor
wjiang edited the summary of this revision. (Show Details)Aug 6 2017, 11:03 PM

Bump