Remove all "Phabricator Bot" code
ClosedPublic
Actions

Authored by epriestley on Apr 21 2017, 7:46 PM.

Details

Reviewers

Maniphest Tasks

T1271: Jabber Integration
T2731: remote control of Bot via external API
T7800: Allow Phabricator IRC bot to connect to channels that require password
T7829: PhabricatorBotFeedNotificationHandler is completely broken and unusable
T7965: phabot / chatbot should supporting connecting through a proxy

Commits

rP5c1e4488deda: Remove all "Phabricator Bot" code

Summary

Closes T7829 as wontfix. Closes T7965 as wontfix. Closes T7800 as wontfix. Closes T2731 as wontfix. Closes T1271 as wontfix.

We aren't maintaining this at all (see, e.g., T7829) and a user reported a technically accurate security issue via HackerOne: https://hackerone.com/reports/222870

Just throw it away until we get to the eventual Conphernece bot/API update and can do this stuff correctly.

Test Plan

Grepped for phabricatorbot.

Diff Detail

Repository

rP Phabricator

Branch

bot1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 16636
Build 22184: Run Core Tests
Build 22183: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 21 2017, 7:46 PM

happycat

This revision is now accepted and ready to land.Apr 21 2017, 7:46 PM

epriestley edited the summary of this revision. (Show Details)Apr 21 2017, 7:47 PM

Harbormaster completed remote builds in B16636: Diff 42708.Apr 21 2017, 7:48 PM

Closed by commit rP5c1e4488deda: Remove all "Phabricator Bot" code (authored by epriestley, committed by epriestley). · Explain WhyApr 21 2017, 7:48 PM

This revision was automatically updated to reflect the committed changes.

reed added a subscriber: reed.Apr 21 2017, 8:48 PM

We use the bot quite heavily at my company. Is there anything stopping me from just copying the deleted code into a libphutil extension and continuing to use it? Really, PhabricatorBotLogHandler is what we care about most.

That'll work fine.

joshuaspence mentioned this in D18378: Remove chatbot example configuration.Aug 9 2017, 10:11 PM

joshuaspence mentioned this in rPbd47d001b548: Remove chatbot example configuration.Aug 9 2017, 10:49 PM

epriestley mentioned this in T8132: Webhook Support.Dec 26 2017, 5:38 PM

epriestley mentioned this in T13372: Permanently remove references to "phd.bots" in "core/".Aug 11 2019, 3:40 PM

After 2.5 years of not upgrading because I didn't want to lose phabot, we finally have (went fairly smoothly yay). Is there a slightly less terse explanation for how I can do as @joshuaspence said? Or at least a pointer to the right documentation for such a project?

We use the bot quite heavily at my company. Is there anything stopping me from just copying the deleted code into a libphutil extension and continuing to use it? Really, PhabricatorBotLogHandler is what we care about most.

Thanks!