Page MenuHomePhabricator
Differential D17736

Add initial infrastructure for adding ModularTransaction support to Application config changes
ClosedPublic
Actions

Authored by amckinley on Apr 19 2017, 10:21 PM.
Tags
None
Referenced Files
F18842962: D17736.diff
Tue, Oct 28, 7:58 PM
F18813502: D17736.id42664.diff
Mon, Oct 20, 4:57 PM
F18777713: D17736.id42663.diff
Sat, Oct 11, 4:43 AM
F18733561: D17736.id.diff
Sep 30 2025, 10:37 PM
F18724280: D17736.id.diff
Sep 30 2025, 3:28 AM
F18566201: D17736.id.diff
Sep 9 2025, 2:23 PM
F18500885: D17736.diff
Sep 4 2025, 9:24 PM
F18096253: D17736.id42663.diff
Aug 8 2025, 5:42 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T11476: Record transaction histories when users edit application capabilities
Commits
rPfebd68039fdc: Add initial infrastructure for adding ModularTransaction support to Application…
Summary

Part of the groundwork for T11476.

Test Plan

ran ./bin/storage upgrade and observed expected DB tables

Diff Detail

Repository
rP Phabricator
Branch
T11476 (branched from master)
Lint
Lint Passed
Unit
Tests Skipped
Build Status
Buildable 16598
Build 22130: Run Core Tests
Build 22129: arc lint + arc unit

Event Timeline

amckinley created this revision.Apr 19 2017, 10:21 PM
Herald added a subscriber: Korvin. · View Herald TranscriptApr 19 2017, 10:21 PM
Harbormaster failed remote builds in B16598: Diff 42663!Apr 19 2017, 10:22 PM
epriestley accepted this revision.Apr 19 2017, 10:26 PM

That build failure is harmless and should fix itself after I counter-diff you for Application extending LiskDAO.

This revision is now accepted and ready to land.Apr 19 2017, 10:26 PM
Closed by commit rPfebd68039fdc: Add initial infrastructure for adding ModularTransaction support to Application… (authored by amckinley, committed by amckinley). · Explain WhyApr 19 2017, 10:45 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 42663

View Options

resources/sql/autopatches/20170418.1.application.01.xaction.sql

Loading...
View Options

resources/sql/autopatches/20170418.1.application.02.edge.sql

Loading...
View Options

src/applications/base/PhabricatorApplication.php

Loading...
View Options

src/applications/meta/query/PhabricatorApplicationApplicationTransactionQuery.php

Loading...
View Options

src/applications/meta/storage/PhabricatorApplicationApplicationTransactionComment.php

Loading...
View Options

src/applications/meta/xactions/PhabricatorApplicationApplicationTransaction.php

Loading...
View Options

src/applications/meta/xactions/PhabricatorApplicationTransactionType.php

Loading...
View Options

src/infrastructure/storage/patch/PhabricatorBuiltinPatchList.php

Loading...
Phabricator · Built by Phacility