HomePhabricator

Switch File deletion to use ModularTransactions

Description

Switch File deletion to use ModularTransactions

Summary: Fixes T12587. Adds a new PhabricatorFileDeleteTransaction that enqueues File delete tasks.

Test Plan:

  • hack PhabricatorFileQuery to ignore isDeleted state
  • stop daemons
  • upload a file, delete it from the UI
  • check that the DB has updated isDeleted = 1
  • check timeline rendering in File detail view
  • start daemons
  • confirm rows are deleted from DB

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, thoughtpolice

Maniphest Tasks: T12587

Differential Revision: https://secure.phabricator.com/D17723

Details

Provenance
amckinleyAuthored on Apr 18 2017, 7:48 PM
amckinleyPushed on Apr 18 2017, 8:01 PM
Reviewer
epriestley
Differential Revision
D17723: Switch File deletion to use ModularTransactions
Parents
rPab2aa74d6e29: Fix several duplication/replay behaviors in Aphlict
Branches
Unknown
Tags
Unknown
Tasks
T12587: Migrate file deletion to modular transactions
Build Status
Buildable 16562
Build 22073: Run Core Tests