Page MenuHomePhabricator

Cleanup Countdown manual construction of monograms/uris
ClosedPublic

Authored by amckinley on Apr 12 2017, 8:26 PM.

Details

Summary

looked for places where Countdown monograms/uris were being constructed by hand, and updated with modern versions

Test Plan

clicked around the Countdown UI, looking for broken links

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

amckinley created this revision.Apr 12 2017, 8:26 PM
epriestley accepted this revision.Apr 12 2017, 8:28 PM
This revision is now accepted and ready to land.Apr 12 2017, 8:28 PM
amckinley added inline comments.Apr 12 2017, 8:28 PM
src/applications/countdown/phid/PhabricatorCountdownCountdownPHIDType.php
39

Is there a better way to do this? I also couldn't figure out how to test this.

epriestley added inline comments.Apr 12 2017, 8:29 PM
src/applications/countdown/phid/PhabricatorCountdownCountdownPHIDType.php
39

You can pht('%s: %s', $countdown->getMonogram(), $name). Not sure that's actually better but maybe looks a little cleaner.

It's currently unclear whether pht('%s: %s', ..., ...) will be helpful (since, say, Chinese users would rather have 🐳 as a separator than :) or harmful (since, say, no one wants to translate or can figure out what it's supposed to mean) when we actually internationalize.

I'm inclined to use pht() just to avoid the evils of string concatenation.

chad added a subscriber: chad.Apr 12 2017, 8:32 PM

I recall French needing a space between : and label

This revision was automatically updated to reflect the committed changes.